Skip to content

[Eager] Refactor TensorAdd by template#39282

Merged
wanghuancoder merged 3 commits intoPaddlePaddle:developfrom
veyron95:rafactor_gradient_accumulator_by_template
Jan 28, 2022
Merged

[Eager] Refactor TensorAdd by template#39282
wanghuancoder merged 3 commits intoPaddlePaddle:developfrom
veyron95:rafactor_gradient_accumulator_by_template

Conversation

@veyron95
Copy link
Copy Markdown
Contributor

PR types

Others

PR changes

Others

Describe

  1. Refactor TensorAdd func by template in gradient_accumulater.cc
  2. Remove gradient_accumulation.c and .h in eager/accumulation
  3. Include gradient_accumulator.h instead of including gradient_accumulation.h

@paddle-bot-old
Copy link
Copy Markdown

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Copy Markdown
Contributor

@JiabinYang JiabinYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use overload instead of template

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thx.

@veyron95 veyron95 force-pushed the rafactor_gradient_accumulator_by_template branch from 2e1a9d2 to cbc99da Compare January 27, 2022 12:58
Copy link
Copy Markdown
Contributor

@JiabinYang JiabinYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wanghuancoder wanghuancoder merged commit 0bb3e5f into PaddlePaddle:develop Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants