[Refactoring Tensor PR #2] changes allocator type, test=develop #38946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Shixiaowei02
force-pushed
the
dev/storage_3
branch
from
cbe5c7c to
eb8aefd
Compare
chenwhql
approved these changes
Jan 15, 2022
jim19930609
reviewed
Jan 15, 2022
jim19930609
approved these changes
Jan 15, 2022
Contributor
jim19930609
left a comment
jim19930609
left a comment
There was a problem hiding this comment.
Approved.
In a consecutive PR, you may consider adding some more comments on how "Allocator* alloc_" will be modified/refactored together with the clean up for "Storage" in the future, or adding some validation checks to guarantee the robustness.
Contributor
Author
Ok, I will remove the Storage member in Tensor as soon as possible and ask you to review the code. |
XieYunshen
approved these changes
Jan 15, 2022
raindrops2sea
approved these changes
Jan 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
APIs
Describe
将 DenseTensor 的构造函数改为支持 Allocator 的形式，以与框架单例解耦。