Skip to content

Make attribute support for std::vector<std::pair<int, int>>#3878

Merged
wanghaoshuang merged 1 commit into
PaddlePaddle:developfrom
wanghaoshuang:fix_attr
Sep 6, 2017
Merged

Make attribute support for std::vector<std::pair<int, int>>#3878
wanghaoshuang merged 1 commit into
PaddlePaddle:developfrom
wanghaoshuang:fix_attr

Conversation

@wanghaoshuang
Copy link
Copy Markdown
Contributor

@wanghaoshuang wanghaoshuang commented Sep 5, 2017

fix #3877

@JiayiFeng
Copy link
Copy Markdown
Collaborator

JiayiFeng commented Sep 5, 2017 •
edited
Loading

Why std::vector<std::pair<int, int>> is necessary? How will it be used as a pad Op attribute?

@wanghaoshuang
Copy link
Copy Markdown
Contributor Author

wanghaoshuang commented Sep 6, 2017

@Canpio
std::vector<std::pair<int, int>> is used to describe the rules of padding. For a 2-d image input, [(0,1), (2,3)] means left_pad=0, right_pad=1, top_pad=2 and bottom_pad=3.

JiayiFeng
JiayiFeng approved these changes Sep 6, 2017
View reviewed changes
Copy link
Copy Markdown
Collaborator

@JiayiFeng JiayiFeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wanghaoshuang wanghaoshuang merged commit 7002e69 into PaddlePaddle:develop Sep 6, 2017
@wanghaoshuang wanghaoshuang deleted the fix_attr branch May 20, 2022 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JiayiFeng JiayiFeng JiayiFeng approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make attribute support for std::vector<std::pair<int, int>>

2 participants

@wanghaoshuang @JiayiFeng