Skip to content

[Bug fix] Fix for MKLDNNDeviceContext error in matmul_v2_transpose_reshape fuse pass when GLOG_v set#38554

Merged
jiweibo merged 2 commits intoPaddlePaddle:developfrom
jakpiase:matmulv2_glog_fix_new
Dec 31, 2021
Merged

[Bug fix] Fix for MKLDNNDeviceContext error in matmul_v2_transpose_reshape fuse pass when GLOG_v set#38554
jiweibo merged 2 commits intoPaddlePaddle:developfrom
jakpiase:matmulv2_glog_fix_new

Conversation

@jakpiase
Copy link
Copy Markdown
Contributor

@jakpiase jakpiase commented Dec 29, 2021

PR types

Bug fixes

PR changes

Others

Describe

Fix for MKLDNNDeviceContext error when GLOG_v env variable was set. It is a fix for #38038 and a reupload of #38411. All this PR does is skipping checking cache if it is empty

@paddle-bot-old
Copy link
Copy Markdown

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@jakpiase jakpiase added the Intel label Dec 29, 2021
@jakpiase
Copy link
Copy Markdown
Contributor Author

@pawelpiotrowicz Please review this PR

Copy link
Copy Markdown
Contributor

@pawelpiotrowicz pawelpiotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown

@wozna wozna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakpiase
Copy link
Copy Markdown
Contributor Author

Hi @Aganlengzi could you please review and merge this PR?

@Aganlengzi
Copy link
Copy Markdown
Contributor

Hi @Aganlengzi could you please review and merge this PR?

@baoachun Plz help review and merge this PR~ for #38038 and #38411

Copy link
Copy Markdown
Contributor

@baoachun baoachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiweibo jiweibo merged commit 1d31764 into PaddlePaddle:develop Dec 31, 2021
@lidanqing-vv lidanqing-vv changed the title Fix for MKLDNNDeviceContext error in matmul_v2_transpose_reshape fuse pass when GLOG_v set [Bug fix] Fix for MKLDNNDeviceContext error in matmul_v2_transpose_reshape fuse pass when GLOG_v set Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants