add dirichlet random sample op in cpu and gpu kernel #38244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
cxxly
force-pushed
the
dirichlet-sample
branch
from
90af7b6 to
c8f7829
Compare
cxxly
force-pushed
the
dirichlet-sample
branch
from
c8f7829 to
fa04fa8
Compare
cxxly
force-pushed
the
dirichlet-sample
branch
from
fa04fa8 to
c8a90d5
Compare
cxxly
force-pushed
the
dirichlet-sample
branch
from
c8a90d5 to
94ecdc0
Compare
cxxly
force-pushed
the
dirichlet-sample
branch
from
94ecdc0 to
f346b2b
Compare
cxxly
changed the title
cxxly
changed the title
jeff41404
reviewed
Dec 24, 2021
Comment on lines
23
to
41
Contributor
There was a problem hiding this comment.
macro's name use underline delimited all capital charactor nomenclature
jeff41404
reviewed
Dec 24, 2021
Contributor
There was a problem hiding this comment.
The first letter of template parameter should be capitalized.
jeff41404
reviewed
Dec 24, 2021
Comment on lines
31
to
38
Contributor
There was a problem hiding this comment.
macro's name use underline delimited all capital charactor nomenclature
jeff41404
reviewed
Dec 24, 2021
Comment on lines
81
to
82
Contributor
There was a problem hiding this comment.
The first letter of template parameter should be capitalized.
jeff41404
reviewed
Dec 24, 2021
Contributor
There was a problem hiding this comment.
The first letter of template parameter should be capitalized.
* WIP: add dirichlet sample op * add cuda kernel for dirichlet op
cxxly
force-pushed
the
dirichlet-sample
branch
from
f346b2b to
818d4fa
Compare
TCChenlong
approved these changes
Dec 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Describe
Dirichlet and Beta distribution API need fast dirichlet random generator for draw sample data, we implement it in cpu and cuda backend use reject-accept sample and inverse-transform sample method.