Simplify the CMakeLists for paddle/operator and paddle/pybind#3801
Merged
luotao1 merged 2 commits intoPaddlePaddle:developfrom Sep 1, 2017
luotao1:op_cmake
Merged
Simplify the CMakeLists for paddle/operator and paddle/pybind#3801luotao1 merged 2 commits intoPaddlePaddle:developfrom luotao1:op_cmake
luotao1 merged 2 commits intoPaddlePaddle:developfrom
luotao1:op_cmake
Conversation
typhoonzero
reviewed
Sep 1, 2017
paddle/operators/CMakeLists.txt
Outdated
| cc_test(net_op_test SRCS net_op_test.cc DEPS net_op) | ||
|
|
||
| op_library(add_op SRCS add_op.cc add_op.cu) | ||
| set(OP_WITHOUT_DEPS |
Contributor
There was a problem hiding this comment.
Sorting op names manually seems inconvenient and can be wrong of order. Maybe we can:
- find op source files under specific folder:
ALL_OPS - define a list containing ops that need to setup manually, including
FRAMEWORK_OP(net_op), and ops needOP_DEPS - exclude
FRAMEWORK_OPandOP_DEPSfromALL_OPS, generatingGENERAL_OPS - sort
GENERAL_OPS - call
op_library
Contributor
Author
There was a problem hiding this comment.
Thx for your comment, I will refine it.
But net_op is similar to other ops, so we don't need FRAMEWORK_OP
typhoonzero
reviewed
Sep 1, 2017
Contributor
typhoonzero
left a comment
typhoonzero
left a comment
There was a problem hiding this comment.
Should update https://github.com/PaddlePaddle/Paddle/blob/develop/doc/howto/dev/new_op_cn.md this document too.
heavengate
pushed a commit
to heavengate/Paddle
that referenced
this pull request
Aug 16, 2021
heavengate
pushed a commit
to heavengate/Paddle
that referenced
this pull request
Aug 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #3800