Skip to content

[new-exec] cache exception in child thread #36692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 26, 2021
Merged

[new-exec] cache exception in child thread #36692

merged 3 commits into from
Oct 26, 2021

Conversation

@zhiqiu
Copy link
Contributor

@zhiqiu zhiqiu commented Oct 25, 2021

PR types

Function optimization

PR changes

Others

Describe

cache exception in child thread to avoid signal abort

  • before
    image
  1. Except for the real exception, another signal abort is raised, which is confusing.
  2. The python call stack is not show.
  • after
    image
    ...
    image

@paddle-bot-old
Copy link

paddle-bot-old bot commented Oct 25, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@zhiqiu zhiqiu merged commit 87fbbd3 into PaddlePaddle:develop Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phlrain phlrain phlrain approved these changes

@liutiexing liutiexing liutiexing approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zhiqiu @phlrain @liutiexing