Skip to content

Added softplus + activation oneDNN fuse pass#36657

Merged
lidanqing-vv merged 12 commits intoPaddlePaddle:developfrom
jakpiase:softplus_activation_fuse_pass
Nov 11, 2021
Merged

Added softplus + activation oneDNN fuse pass#36657
lidanqing-vv merged 12 commits intoPaddlePaddle:developfrom
jakpiase:softplus_activation_fuse_pass

Conversation

@jakpiase
Copy link
Contributor

@jakpiase jakpiase commented Oct 22, 2021 •
edited by lelelelelez
Loading

PR types

New features

PR changes

OPs

Describe

Added softplus + activation oneDNN fuse pass. It improved ppyolov3_r50vd_dcn_365 performance by 0.7%

@paddle-bot-old
Copy link

paddle-bot-old bot commented Oct 22, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@jakpiase jakpiase added the Intel label Oct 22, 2021
@jakpiase jakpiase requested a review from jczaja October 22, 2021 19:00
@jakpiase
Copy link
Contributor Author

jakpiase commented Oct 22, 2021

@tsocha Please review that PR

jczaja
jczaja reviewed Oct 25, 2021
View reviewed changes
tsocha
tsocha reviewed Oct 25, 2021
View reviewed changes
tsocha
tsocha previously approved these changes Oct 25, 2021
View reviewed changes
tsocha
tsocha previously approved these changes Oct 25, 2021
View reviewed changes
@jakpiase
Copy link
Contributor Author

jakpiase commented Oct 27, 2021

@lidanqing-intel Could you please ask somebody from Baidu to approve PR-CI-Static-Check?

@lidanqing-vv
Copy link
Contributor

lidanqing-vv commented Oct 27, 2021

@baoachun Could you please help request following people to approve this PR-CI-Static-Check? Or should we change anything to make CI to pass itself? Thanks !

2021-10-27 19:50:15 ****************
2021-10-27 19:50:15 Please find RD for approval first, and then find TPM for approval.
2021-10-27 19:50:15 0. You must have  one TPM approval for API documents change:
2021-10-27 19:50:15  jzhang533/ZhangJun, dingjiaweiww/DingJiaWei, Heeenrrry/LiKunLun, TCChenlong/ChenLong for general API docs
2021-10-27 19:50:15  PangHua/XiangHui for distributed related API docs
2021-10-27 19:50:15  twismon/WangYunKai, CheQiXiao/CheQiXiao for inference related API docs.
``

lidanqing-vv
lidanqing-vv reviewed Oct 28, 2021
View reviewed changes
jczaja
jczaja previously approved these changes Oct 29, 2021
View reviewed changes
@lidanqing-vv lidanqing-vv changed the title Added softplus + activation oneDNN fuse pass [No-docker-pre-commit] Added softplus + activation oneDNN fuse pass Nov 2, 2021
@lidanqing-vv lidanqing-vv changed the title [No-docker-pre-commit] Added softplus + activation oneDNN fuse pass [Need-docker-pre-commit] Added softplus + activation oneDNN fuse pass Nov 2, 2021
@lidanqing-vv lidanqing-vv changed the title [Need-docker-pre-commit] Added softplus + activation oneDNN fuse pass [pre-committed-but-CI-fail] Added softplus + activation oneDNN fuse pass Nov 3, 2021
@lidanqing-vv lidanqing-vv changed the title [pre-committed-but-CI-fail] Added softplus + activation oneDNN fuse pass [Pre-committed-but-CI-fail] Added softplus + activation oneDNN fuse pass Nov 3, 2021
@jakpiase jakpiase requested a review from jczaja November 4, 2021 09:06
@lidanqing-vv lidanqing-vv changed the title [Pre-committed-but-CI-fail] Added softplus + activation oneDNN fuse pass [Waiting email] Added softplus + activation oneDNN fuse pass Nov 4, 2021
@jczaja
Copy link
Contributor

jczaja commented Nov 8, 2021

@baoachun, @lidanqing-intel Please help to have this PR approved so it pass CI Static Check

@baoachun
Copy link
Contributor

baoachun commented Nov 9, 2021

@baoachun, @lidanqing-intel Please help to have this PR approved so it pass CI Static Check

I have communicated with my colleague, but he has not yet approve this pr, I will urge it tomorrow.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Nov 10, 2021

Sorry to inform you that 123dbf6's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@jakpiase jakpiase changed the title [Waiting email] Added softplus + activation oneDNN fuse pass Added softplus + activation oneDNN fuse pass Nov 10, 2021
@baoachun
Copy link
Contributor

baoachun commented Nov 10, 2021

Hi @jczaja, could you please merge the latest develop branch and push again? My colleague said that the reason for the failure may be that the latest code was not pulled.

@lidanqing-vv
Copy link
Contributor

lidanqing-vv commented Nov 10, 2021

@baoachun Now only one required CI not passing: PR-CE-Framework, restarted and wait for results.

@lidanqing-vv lidanqing-vv merged commit a346c4d into PaddlePaddle:develop Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TCChenlong TCChenlong TCChenlong approved these changes

+4 more reviewers

@arlesniak arlesniak arlesniak left review comments

@lidanqing-vv lidanqing-vv lidanqing-vv left review comments

@jczaja jczaja jczaja approved these changes

@tsocha tsocha tsocha left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Intel

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jakpiase @lidanqing-vv @jczaja @baoachun @TCChenlong @arlesniak @tsocha