add fp16 unittests for kl2 #36583
Merged
add fp16 unittests for kl2 #36583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
tangzhiyi11
reviewed
Oct 25, 2021
paddle/fluid/pybind/pybind.cc
Outdated
Contributor
There was a problem hiding this comment.
是否可以在接口名里加上xpu信息来表明这个接口是专门给xpu设备用的？
Contributor
Author
There was a problem hiding this comment.
这个是为了GPU一致，GPU也是有这个接口，一样的名字，我这里就沿用了。
Contributor
There was a problem hiding this comment.
顺便加个int64类型吧，api里已经支持了
Contributor
Author
There was a problem hiding this comment.
这int64的kl1不支持，应该先在api里面增加了 kl1的支持后，再增加绑定这个接口。现在kl1和kl2只是做了fp16的区分。
Contributor
Author
There was a problem hiding this comment.
已经增加了注册，单测是跑不了的。缺少mean的int64的支持，cpu的单测都没有跑int64
Contributor
|
LGTM |
jiweibo
approved these changes
Oct 26, 2021
fuyinno4
approved these changes
Oct 27, 2021
ghost
pushed a commit
to piotrekobi/Paddle
that referenced
this pull request
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
add fp16 unittests for kl2
*test=kunlun