[Cherry-pick]FFT function enhancements and bugfixes by cxxly · Pull Request #36537 · PaddlePaddle/Paddle

cxxly · 2021-10-19T07:58:49Z

PR types

New features

PR changes

APIs

Describe

cherry-pick of following PRs:

add rocm support for fft api (add rocm support for fft api #36415)
dynamic load mkl as a fft backend when it is avaialble and requested (dynamic load mkl as a fft backend when it is avaialble and requested #36414)
fft: modify sample code result (modify sample code result #36325)
use unified external error message for cufft api (using unified external error message for cufft api #36114)
fix fft axis (fix fft axis #36321)
update fft api path (update fft api path #36219)
move fft and signal paths (move fft and signal files, move signal APIs #36540)
Add LRUCache for fft plans (Add LRUCache for fft plans #36646)
roll_op: support Tensor as input for shifts (roll_op: support Tensor as input for shifts #36727)
fix fftshift/ifftshift on static mode (fix fftshift/ifftshift on static mode #36748)

* update fft api path * add sample code for ihfft2 Co-authored-by: chenfeiyu <[email protected]>

fix: `-1` is used when fft's axis is `0`

…addlePaddle#36414)

paddle-bot-old · 2021-10-19T07:58:52Z

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

…uffix move signal apis

jeff41404

lgtm

* move signal apis * move fft.py and signal.py to paddle/, fix typos * fix relative imports from fft.py and signal.py

* move signal apis * move fft.py and signal.py to paddle/, fix typos * fix relative imports from fft.py and signal.py * fix typos

XiaoguangHu01

LGTM

* move signal apis * move fft.py and signal.py to paddle/, fix typos * fix relative imports from fft.py and signal.py * fix typos * Add LRUCache for fft plans

* move signal apis * move fft.py and signal.py to paddle/, fix typos * fix relative imports from fft.py and signal.py * fix typos * WIP: add cache * delete move constructor and operator= for CuFFTHandle and FFTConfig * remove log from CuFFTHandle and FFTConfig * add lrucache for fft rocm backend * disable LRUCache when CUFFT_VERSION >= 10200 * disbale copy and move for hipFFTHandle; format code Co-authored-by: Xiaoxu Chen <[email protected]>

wadefelix · 2021-10-27T01:46:26Z


 python3.7 spider.py
-tar czvf externalErrorMsg.tar.gz externalErrorMsg.pb
+tar czvf externalErrorMsg_$(date +'%Y%m%d').tar.gz externalErrorMsg.pb


这个地方为什么要打压缩包？

这个也是延续之前的做法，此前就是用压缩包的，可能是和其他依赖文件一样的习惯。
事实上对于小文件，甚至可以直接包含在 repo 里面。

wadefelix · 2021-10-27T01:47:28Z

+
+   ```
+   set(URL  "https://paddlepaddledeps.bj.bcebos.com/externalErrorMsg_20210928.tar.gz" CACHE STRING "" FORCE)
+   file_download_and_uncompress(${URL} "externalError" MD5 a712a49384e77ca216ad866712f7cafa)


我建议bos上提供一个 https://paddlepaddledeps.bj.bcebos.com/externalErrorMsg_20210928.tar.gz.md5sum 文件用来校验。

这个可以在后期来一波全面的修改，因为 cmake 文件里面几乎都是把 MD5 写在了文件里。我们也遵循了习惯。

wadefelix · 2021-10-27T01:49:12Z

-    set(URL  "https://paddlepaddledeps.bj.bcebos.com/externalErrorMsg.tar.gz" CACHE STRING "" FORCE)
-    file_download_and_uncompress(${URL} "externalError" MD5 061f3b7895aadcbe2c3ed592590f8b10)   # download file externalErrorMsg.tar.gz
+    set(URL  "https://paddlepaddledeps.bj.bcebos.com/externalErrorMsg_20210928.tar.gz" CACHE STRING "" FORCE)
+    file_download_and_uncompress(${URL} "externalError" MD5 a712a49384e77ca216ad866712f7cafa)   # download file externalErrorMsg.tar.gz


建议提供一个 https://paddlepaddledeps.bj.bcebos.com/externalErrorMsg_20210928.tar.gz.md5sum 文件以供校验。
这是比较符合软件下载的常见的一种校验值提供方式。

我们这里是延续 paddle 之前的做法，md5 都写在了代码里。

如果这是一个好的校验值提供方式，那么后续可以来一波全面的更改。

XiaoguangHu01

LGTM

zhiboniu and others added 6 commits October 19, 2021 07:27

update fft api path (PaddlePaddle#36219)

b00e7a3

* update fft api path * add sample code for ihfft2 Co-authored-by: chenfeiyu <[email protected]>

fix fft axis (PaddlePaddle#36321)

b01cbdb

fix: `-1` is used when fft's axis is `0`

use unified external error message for cufft api (PaddlePaddle#36114)

5d054d0

fft: modify sample code result (PaddlePaddle#36325)

14e553e

dynamic load mkl as a fft backend when it is avaialble and requested (P…

12cbd4e

…addlePaddle#36414)

add rocm support for fft api (PaddlePaddle#36415)

01d9d07

chenfeiyu and others added 2 commits October 19, 2021 17:05

move signal apis

5244c94

Merge pull request #1 from iclementine/fft-function-enhancement-and-b…

377096a

…uffix move signal apis

jeff41404 previously approved these changes Oct 20, 2021

View reviewed changes

cxxly changed the title ~~FFT function enhancements and bugfixes~~ [Cherry-pick]FFT function enhancements and bugfixes Oct 20, 2021

move fft and signal API path (#2)

3f605d8

* move signal apis * move fft.py and signal.py to paddle/, fix typos * fix relative imports from fft.py and signal.py

cxxly dismissed jeff41404’s stale review via 3f605d8 October 20, 2021 05:01

fix typos in signal.py (#3)

fe35170

* move signal apis * move fft.py and signal.py to paddle/, fix typos * fix relative imports from fft.py and signal.py * fix typos

iclementine mentioned this pull request Oct 25, 2021

Add LRUCache for cufft and hipfft #36715

Closed

XiaoguangHu01 previously approved these changes Oct 26, 2021

View reviewed changes

disable Cache when CUFFT_VERSION >= 10200 (#4)

7b1c8ae

* move signal apis * move fft.py and signal.py to paddle/, fix typos * fix relative imports from fft.py and signal.py * fix typos * Add LRUCache for fft plans

cxxly dismissed XiaoguangHu01’s stale review via 7b1c8ae October 26, 2021 13:15

Feiyu Chan and others added 6 commits October 26, 2021 22:21

remove debug message of cufftHandler

d30b4be

roll_op: support Tensor as input for shifts (PaddlePaddle#36727)

a2e456a

fix fftshift/ifftshift on static mode

4e22f40

update roll_op version

6e2fa31

add more test cases for fftshift/ifftshift

c5d92f3

wadefelix reviewed Oct 27, 2021

View reviewed changes

chenwhql approved these changes Oct 27, 2021

View reviewed changes

XiaoguangHu01 approved these changes Oct 27, 2021

View reviewed changes

raindrops2sea approved these changes Oct 27, 2021

View reviewed changes

XiaoguangHu01 merged commit 11b9f5f into PaddlePaddle:release/2.2 Oct 28, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Cherry-pick]FFT function enhancements and bugfixes#36537

[Cherry-pick]FFT function enhancements and bugfixes#36537
XiaoguangHu01 merged 17 commits intoPaddlePaddle:release/2.2from
cxxly:fft-function-enhancement-and-buffix

cxxly commented Oct 19, 2021 •

edited by iclementine

Loading

Uh oh!

paddle-bot-old Bot commented Oct 19, 2021

Uh oh!

jeff41404 left a comment

Uh oh!

XiaoguangHu01 left a comment

Uh oh!

wadefelix Oct 27, 2021

Uh oh!

iclementine Oct 27, 2021

Uh oh!

wadefelix Oct 27, 2021

Uh oh!

iclementine Oct 27, 2021

Uh oh!

wadefelix Oct 27, 2021

Uh oh!

iclementine Oct 27, 2021 •

edited

Loading

Uh oh!

XiaoguangHu01 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Conversation

cxxly commented Oct 19, 2021 • edited by iclementine Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR types

PR changes

Describe

Uh oh!

paddle-bot-old Bot commented Oct 19, 2021

Uh oh!

jeff41404 left a comment

Choose a reason for hiding this comment

Uh oh!

XiaoguangHu01 left a comment

Choose a reason for hiding this comment

Uh oh!

wadefelix Oct 27, 2021

Choose a reason for hiding this comment

Uh oh!

iclementine Oct 27, 2021

Choose a reason for hiding this comment

Uh oh!

wadefelix Oct 27, 2021

Choose a reason for hiding this comment

Uh oh!

iclementine Oct 27, 2021

Choose a reason for hiding this comment

Uh oh!

wadefelix Oct 27, 2021

Choose a reason for hiding this comment

Uh oh!

iclementine Oct 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

XiaoguangHu01 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

cxxly commented Oct 19, 2021 •

edited by iclementine

Loading

iclementine Oct 27, 2021 •

edited

Loading