Skip to content

Second fix to #34554 #36290

Merged
lidanqing-vv merged 1 commit intoPaddlePaddle:developfrom
jczaja:prv-34554-fix2
Oct 13, 2021
Merged

Second fix to #34554 #36290
lidanqing-vv merged 1 commit intoPaddlePaddle:developfrom
jczaja:prv-34554-fix2

Conversation

@jczaja
Copy link
Contributor

@jczaja jczaja commented Oct 8, 2021

PR types

Bug fixes

PR changes

Others

Describe

Clearing of caching mechanism

@paddle-bot-old
Copy link

paddle-bot-old bot commented Oct 8, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@jczaja jczaja added the Intel label Oct 8, 2021
@jczaja
Implemented LRU based cache clearing
006f33f 
- Lint

- Merge with develop

- lint
jakpiase
jakpiase approved these changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@jakpiase jakpiase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lidanqing-vv
lidanqing-vv approved these changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@lidanqing-vv lidanqing-vv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lidanqing-vv
Copy link
Contributor

lidanqing-vv commented Oct 13, 2021 •
edited
Loading

@OliverLPH Hi, this is last fix, Could you please verify on Baidu 6271? And does these fix PRs need to be cherry-picked to release/2.2 ?

@OliverLPH
Copy link
Contributor

OliverLPH commented Oct 13, 2021

@lidanqing-intel could you please merge it into develop first.
later this week I will verify the latest develop Paddle. If it works fine, then cherry-pick to release/2.2 ?

@lidanqing-vv lidanqing-vv merged commit bf748f2 into PaddlePaddle:develop Oct 13, 2021
@jczaja
Copy link
Contributor Author

jczaja commented Oct 13, 2021

@OliverLPH I discovered some problems (crashes) in issue #34554 with this PR merged. So it is not yet solved. I'm still investigating. If you have any observations please write them in #34554 as it was helpful for me some easier reproductions you have described.

lidanqing-vv added a commit to lidanqing-vv/Paddle that referenced this pull request Oct 14, 2021
@lidanqing-vv
Revert "Implemented LRU based cache clearing (PaddlePaddle#36290)"
3c2fdc6 
This reverts commit bf748f2.
@lidanqing-vv lidanqing-vv mentioned this pull request Oct 14, 2021
Merged
@qili93
Copy link
Contributor

qili93 commented Oct 14, 2021

Hi @lidanqing-intel,

This PR broken Paddle compile on ARM due to missing header file of "x86intrin.h" in aarch64 environment.

Please kindly help to revert this PR and fix, thanks!

f6397938193206bc73c70b7df9cc1257

lidanqing-vv added a commit that referenced this pull request Oct 14, 2021
@lidanqing-vv
Revert "Implemented LRU based cache clearing (#36290)" (#36426)
5d18967 
This reverts commit bf748f2.
@lidanqing-vv
Copy link
Contributor

lidanqing-vv commented Oct 14, 2021 •
edited
Loading

@qili93 Hi, revert PR Revert #36426 is merged just now, could you please verify latest develop again if compiling on ARM works? Sorry for inconvenience. Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@lidanqing-vv lidanqing-vv lidanqing-vv approved these changes

@jakpiase jakpiase jakpiase approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Intel

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jczaja @lidanqing-vv @OliverLPH @qili93 @jakpiase