Skip to content

fix hasattr(paddle.fluid.ir.PassDesc.OP, '__name__') error #36229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 9, 2021
Merged

fix hasattr(paddle.fluid.ir.PassDesc.OP, '__name__') error #36229

merged 3 commits into from
Oct 9, 2021

Conversation

@Avin0323
Copy link
Contributor

@Avin0323 Avin0323 commented Sep 30, 2021

PR types

Others

PR changes

Others

Describe

修复如下图所示问题：

image

对于__getattr__重载后不满足条件的参数，全部抛出AttributeError异常，达到与未重载版本一致。

@paddle-bot-old
Copy link

paddle-bot-old bot commented Sep 30, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

zhhsplendid
zhhsplendid approved these changes Oct 9, 2021
View reviewed changes
Copy link
Member

@zhhsplendid zhhsplendid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhhsplendid zhhsplendid merged commit d8887af into PaddlePaddle:develop Oct 9, 2021
@Avin0323 Avin0323 mentioned this pull request Oct 9, 2021
Merged
lanxianghit pushed a commit that referenced this pull request Oct 11, 2021
@Avin0323
[cherry-pick]fix hasattr(paddle.fluid.ir.PassDesc.OP, '__name__') err…
45de931 
…or (#36294)

对于__getattr__重载后不满足条件的参数，全部抛出AttributeError异常，达到与未重载版本一致。

(cherry picked from PR #36229)
@Avin0323 Avin0323 deleted the fix-has-attr-error branch October 15, 2021 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhhsplendid zhhsplendid zhhsplendid approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Avin0323 @zhhsplendid