Skip to content

Refine FastThreadedSSAGraphExecutor::Run when thread_num = 1 #36201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sneaxiy merged 1 commit into from
Sep 29, 2021
Merged

Refine FastThreadedSSAGraphExecutor::Run when thread_num = 1 #36201

sneaxiy merged 1 commit into from
Sep 29, 2021

Conversation

@sneaxiy
Copy link
Collaborator

@sneaxiy sneaxiy commented Sep 28, 2021

PR types

Others

PR changes

Others

Describe

Prepare traced_ops_ beforehand if thread number is 1.
This PR is prepared for CUDA Graph.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Sep 28, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@sneaxiy sneaxiy requested review from chenwhql and zhiqiu September 29, 2021 00:21
chenwhql
chenwhql approved these changes Sep 29, 2021
View reviewed changes
Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sneaxiy sneaxiy merged commit 7e60cc6 into PaddlePaddle:develop Sep 29, 2021
@sneaxiy sneaxiy deleted the refine_fast_threaded_ssa_graph_executor branch September 29, 2021 02:13
@sneaxiy sneaxiy restored the refine_fast_threaded_ssa_graph_executor branch September 29, 2021 02:13
@sneaxiy sneaxiy deleted the refine_fast_threaded_ssa_graph_executor branch September 29, 2021 02:13
AnnaTrainingG pushed a commit to AnnaTrainingG/Paddle that referenced this pull request Sep 29, 2021
@sneaxiy @AnnaTrainingG
refine case when thread_num = 1 (PaddlePaddle#36201)
d0c596c
sneaxiy added a commit that referenced this pull request Oct 11, 2021
@sneaxiy
Revert "refine case when thread_num = 1 (#36201)"
7c049a0 
This reverts commit 7e60cc6.
@sneaxiy sneaxiy mentioned this pull request Oct 11, 2021
Merged
sneaxiy added a commit that referenced this pull request Oct 12, 2021
@sneaxiy
Revert "refine case when thread_num = 1 (#36201)" (#36347)
0594d2a 
This reverts commit 7e60cc6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenwhql chenwhql chenwhql approved these changes

@zhiqiu zhiqiu Awaiting requested review from zhiqiu

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sneaxiy @chenwhql