add python interface of sub_graph #36120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
huangxu96
force-pushed
the
subgraph_python_interface
branch
from
a0f6bcc to
4167ec4
Compare
huangxu96
force-pushed
the
subgraph_python_interface
branch
from
c30e49b to
7c029dd
Compare
thisjiang
reviewed
Sep 28, 2021
| nodes) #这里 all nodes 不为空，所以可以作量化Pass | ||
| transform_pass.apply(sub_graph) | ||
| print("Done quant pass applied ") | ||
| return all_sub_graphs |
Contributor
There was a problem hiding this comment.
这里返回后main_graph应该就被析构了，而sub_graphs其实只是main_graph的一个成员。
thisjiang
reviewed
Sep 28, 2021
| # loss = linear_fc(3) | ||
| # opt = fluid.optimizer.Adam(learning_rate=0.001) | ||
| # opt.minimize(loss) | ||
| core_graph = core.Graph(main_program.desc) |
Contributor
There was a problem hiding this comment.
我觉得main_graph应该是传入而非函数内部创建，临时变量出作用域后就会被析构，python应该也不例外
thisjiang
reviewed
Sep 28, 2021
| return_value_policy::reference) | ||
| .def("sub_graph_size", &Graph::SubGraphsSize) | ||
| .def("get_sub_graph", [](Graph &self, int i) { | ||
| return std::shared_ptr<Graph>(self.GetSubGraph(i), [](Graph *) {}); |
Contributor
There was a problem hiding this comment.
[](Graph *) {}是为了防止外部析构？不能直接返回裸指针么？
Contributor
Author
There was a problem hiding this comment.
这个是防止double free，目的是让该指针在python析构，不然会在C++和python都析构一次。后面加了注释对这个的解释。
Contributor
There was a problem hiding this comment.
Does return_value_policy::reference work for that?
huangxu96
force-pushed
the
subgraph_python_interface
branch
3 times, most recently
from
ea88f67 to
e0c55cc
Compare
huangxu96
force-pushed
the
subgraph_python_interface
branch
from
e0c55cc to
69b73e6
Compare
huangxu96
force-pushed
the
subgraph_python_interface
branch
from
abaf4cd to
0fc1236
Compare
huangxu96
force-pushed
the
subgraph_python_interface
branch
from
0fc1236 to
b2a088e
Compare
zhiqiu
approved these changes
Oct 8, 2021
| return_value_policy::reference) | ||
| .def("sub_graph_size", &Graph::SubGraphsSize) | ||
| .def("get_sub_graph", [](Graph &self, int i) { | ||
| return std::shared_ptr<Graph>(self.GetSubGraph(i), [](Graph *) {}); |
Contributor
There was a problem hiding this comment.
Does return_value_policy::reference work for that?
huangxu96
added a commit
to huangxu96/Paddle
that referenced
this pull request
Dec 17, 2021
Add python interface of subgraph: 1. all_sub_graphs() 2. get_sub_graph(idx)
lanxianghit
pushed a commit
that referenced
this pull request
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Describe
Add python interface of subgraph: 1. all_sub_graphs() 2. get_sub_graph(idx)