Replace Eigen with Lapack library for "eigvals" OP kernel #35909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
From00
changed the title
From00
changed the title
zhwesky2010
reviewed
Sep 22, 2021
Contributor
zhwesky2010
left a comment
zhwesky2010
left a comment
There was a problem hiding this comment.
LGTM for calling origin lapack API
zhwesky2010
reviewed
Sep 22, 2021
zhiqiu
approved these changes
Sep 23, 2021
From00
added a commit
to From00/Paddle
that referenced
this pull request
Sep 24, 2021
AnnaTrainingG
pushed a commit
to AnnaTrainingG/Paddle
that referenced
this pull request
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
OPs
Describe
This PR implements the kernel of "eigvals" OP with the Lapack library, which has a better performance than the previous Eigen library.
Here are some preliminary test results comparing between two library:
