Skip to content

Add segment apis to paddle.incubate #35759

Merged
ZHUI merged 4 commits intoPaddlePaddle:developfrom
ZHUI:add_segment_api
Sep 16, 2021
Merged

Add segment apis to paddle.incubate #35759
ZHUI merged 4 commits intoPaddlePaddle:developfrom
ZHUI:add_segment_api

Conversation

@ZHUI
Copy link
Copy Markdown
Collaborator

@ZHUI ZHUI commented Sep 15, 2021 •
edited
Loading

PR types

New features

PR changes

APIs

Describe

Add segment apis to paddle.incubate

Segment APIs provide operations (sum, mean, max, min) on certain segment part. Following image demonstrates the process of segment mean. The segment_ids divides the data into 4 parts, and segment_mean calculates the mean of each part.

data = paddle.to_tensor([5.0,1,7,2,3,4,1,3])
segment_ids = paddle.to_tensor([0,0,0,1,2,2,3,3], dtype="int32")
paddle.incubate.segment_mean(data, segment_ids)
# [4.33333349, 2.        , 3.50000000, 2.        ]

@paddle-bot-old
Copy link
Copy Markdown

paddle-bot-old Bot commented Sep 15, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

ZHUI
ZHUI commented Sep 15, 2021
View reviewed changes
Comment thread python/paddle/incubate/tensor/math.py

This operator calculate the maximum elements of input `data` which with
the same index in `segment_ids`.
It computes a tensor such that $out_i = \\min_{j} data_{j}$
Copy link
Copy Markdown
Collaborator Author

@ZHUI ZHUI Sep 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\max

XiaoguangHu01
XiaoguangHu01 approved these changes Sep 16, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread python/paddle/incubate/tensor/math.py
# limitations under the License.

__all__ = [
'segment_sum',
Copy link
Copy Markdown
Contributor

@XiaoguangHu01 XiaoguangHu01 Sep 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里不用加到__all__列表，这个列表会用来统计公开API，只需要在目标位置加一次就行。

Copy link
Copy Markdown
Collaborator Author

@ZHUI ZHUI Sep 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

下个PR进行修复 : #35818

@ZHUI ZHUI merged commit 4b68388 into PaddlePaddle:develop Sep 16, 2021
@ZHUI ZHUI deleted the add_segment_api branch September 17, 2021 06:17
AnnaTrainingG pushed a commit to AnnaTrainingG/Paddle that referenced this pull request Sep 29, 2021
@ZHUI @AnnaTrainingG
Add segment apis to paddle.incubate (PaddlePaddle#35759)
652d1bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TCChenlong TCChenlong TCChenlong approved these changes

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

@wawltor wawltor Awaiting requested review from wawltor

@ZeyuChen ZeyuChen Awaiting requested review from ZeyuChen

@DesmonDay DesmonDay Awaiting requested review from DesmonDay

@LemonNoel LemonNoel Awaiting requested review from LemonNoel

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ZHUI @TCChenlong @XiaoguangHu01