[icafe-31094] Add function comments and instructions to the API #35743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
zkh2016
reviewed
Sep 22, 2021
paddle/fluid/operators/kernel_primitives/datamover_primitives.h
Outdated
Show resolved
Hide resolved
ZzSean
reviewed
Sep 22, 2021
ZzSean
reviewed
Sep 22, 2021
ZzSean
reviewed
Sep 22, 2021
ZzSean
reviewed
Sep 22, 2021
paddle/fluid/operators/kernel_primitives/datamover_primitives.h
Outdated
Show resolved
Hide resolved
ZzSean
reviewed
Sep 22, 2021
xingfeng01
previously approved these changes
Sep 22, 2021
ZzSean
reviewed
Sep 23, 2021
paddle/fluid/operators/kernel_primitives/datamover_primitives.h
Outdated
Show resolved
Hide resolved
AnnaTrainingG
force-pushed
the
Primitive_API_31094
branch
from
3a0031e to
f7531dc
Compare
xingfeng01
previously approved these changes
Sep 24, 2021
JamesLim-sy
reviewed
Sep 24, 2021
Contributor
JamesLim-sy
left a comment
JamesLim-sy
left a comment
There was a problem hiding this comment.
Elementwise相关的API中输入和输出的形参命名是in\out, 但在Reduce相关的API中输入和输出的形参命名是src\dst，是否考虑予以统一。
paddle/fluid/operators/kernel_primitives/datamover_primitives.h
Outdated
Show resolved
Hide resolved
AnnaTrainingG
force-pushed
the
Primitive_API_31094
branch
from
f7531dc to
57c2618
Compare
Contributor
|
LGTM |
zhangting2020
approved these changes
Sep 24, 2021
xingfeng01
approved these changes
Sep 24, 2021
JamesLim-sy
approved these changes
Sep 24, 2021
AnnaTrainingG
added a commit
to AnnaTrainingG/Paddle
that referenced
this pull request
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
[icafe-31094] Add function comments and instructions to the API