-
Notifications
You must be signed in to change notification settings - Fork 6k
GeneratePass for Python Pass #35708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
GeneratePass for Python Pass #35708
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
c80c5fa
GeneratePass for Python Pass, test=develop
Avin0323 f60d6ef
fix unittest error, test=develop
Avin0323 294d515
Merge branch 'develop' into generate-pass
Avin0323 492b3ec
modify according to review comments, test=develop
Avin0323 76e1c91
add unittest to increase coverage, test=develop
Avin0323 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,229 @@ | ||
| // Copyright (c) 2021 PaddlePaddle Authors. All Rights Reserved. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| #include "paddle/fluid/framework/ir/generate_pass.h" | ||
|
|
||
| namespace paddle { | ||
| namespace framework { | ||
| namespace ir { | ||
|
|
||
| void InitGeneratePattern(const proto::PassDesc& pass_desc, PDPattern* pattern) { | ||
| const proto::BlockDesc& block = pass_desc.pattern().blocks(0); | ||
| // Traverse all operators to create subgraph. | ||
| for (int index = 0; index < block.ops_size(); ++index) { | ||
| const proto::OpDesc& op = block.ops(index); | ||
| // Create a PDNode for current operator. Use the index as name to avoid | ||
| // multiple operators with same type. Get a PDNode from pattern subgraph | ||
| // through index in rewrite phase. | ||
| PDNode* op_pdnode = | ||
| pattern->NewNode(std::to_string(index))->assert_is_op(op.type()); | ||
| // Create PDNodes for inputs of current operator. | ||
| for (const proto::OpDesc::Var& var : op.inputs()) { | ||
| for (const std::string& argument : var.arguments()) { | ||
| // The input may be the output of other operator. | ||
| PDNode* var_pdnode = pattern->RetrieveNode(argument); | ||
| if (nullptr == var_pdnode) { | ||
| var_pdnode = pattern->NewNode(argument)->AsInput(); | ||
| } else if (var_pdnode->IsOutput()) { | ||
| var_pdnode->AsIntermediate(); | ||
| } | ||
| var_pdnode->assert_is_op_input(op.type()); | ||
| pattern->AddEdge(var_pdnode, op_pdnode); | ||
| } | ||
| } | ||
| // Create PDNodes for outputs of current operator. | ||
| for (const proto::OpDesc::Var& var : op.outputs()) { | ||
| for (const std::string& argument : var.arguments()) { | ||
| // The output may be the input of other operator. | ||
| PDNode* var_pdnode = pattern->RetrieveNode(argument); | ||
| if (nullptr == var_pdnode) { | ||
| var_pdnode = pattern->NewNode(argument)->AsOutput(); | ||
| } else if (var_pdnode->IsInput()) { | ||
| var_pdnode->AsIntermediate(); | ||
| } | ||
| var_pdnode->assert_is_op_output(op.type()); | ||
| pattern->AddEdge(op_pdnode, var_pdnode); | ||
| } | ||
| } | ||
| // Set attribute condition for current operator. | ||
| for (const proto::OpDesc::Attr& attr : op.attrs()) { | ||
| op_pdnode->assert_more([&](Node* x) { | ||
| if (x && x->IsOp()) { | ||
| OpDesc* op_desc = x->Op(); | ||
| if (op_desc->HasAttr(attr.name())) { | ||
| return GetAttrValue(attr) == op_desc->GetAttr(attr.name()); | ||
| } | ||
| return false; | ||
| } | ||
| return false; | ||
| }); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| GraphPatternDetector::handle_t GetGenerateRewrite( | ||
| const PDPattern& pattern, const proto::PassDesc& pass_desc) { | ||
| GraphPatternDetector::handle_t handler = [&]( | ||
| const GraphPatternDetector::subgraph_t subgraph, Graph* graph) { | ||
| // There are some duplicate patterns. | ||
| for (auto iter : subgraph) { | ||
| if (nullptr == graph->RetrieveNode(iter.second->id())) { | ||
| VLOG(3) << "Node [" << iter.second->Name() | ||
| << "] of subgraph has been removed. So skip this optimize."; | ||
| return; | ||
| } | ||
| } | ||
| const proto::BlockDesc& block = pass_desc.replace().blocks(0); | ||
| // `var_node_maps` record the mapping of variable to the pattern subgraph. | ||
| std::map<std::string, Node*> var_node_maps; | ||
| for (const proto::PassDesc::VarMap& var_map : pass_desc.var_maps()) { | ||
| Node* node = subgraph.at(pattern.RetrieveNode(var_map.pattern_var())); | ||
| var_node_maps.insert({var_map.replace_var(), node}); | ||
| } | ||
| // Traverse all operators to create subgraph. | ||
| for (const proto::OpDesc& op : block.ops()) { | ||
| OpDesc op_desc; | ||
| std::vector<Node *> in_nodes, out_nodes; | ||
| op_desc.SetType(op.type()); | ||
| // Create Nodes for inputs of current operator. | ||
| for (const proto::OpDesc::Var& var : op.inputs()) { | ||
| std::vector<std::string> arguments; | ||
| for (const std::string& argument : var.arguments()) { | ||
| // The input may be mapped on the operator of pattern subgraph. | ||
| Node* node = nullptr; | ||
| auto iter = var_node_maps.find(argument); | ||
| if (var_node_maps.end() == iter) { | ||
| VarDesc var_desc(patterns::UniqueKey(argument)); | ||
| node = graph->CreateVarNode(&var_desc); | ||
| var_node_maps.insert({argument, node}); | ||
| } else { | ||
| node = iter->second; | ||
| } | ||
| in_nodes.push_back(node); | ||
| arguments.push_back(node->Name()); | ||
| } | ||
| op_desc.SetInput(var.parameter(), arguments); | ||
| } | ||
| // Create Nodes for outputs of current operator. | ||
| for (const proto::OpDesc::Var& var : op.outputs()) { | ||
| std::vector<std::string> arguments; | ||
| for (const std::string& argument : var.arguments()) { | ||
| // The output may be mapped on the operator of pattern subgraph. | ||
| Node* node = nullptr; | ||
| auto iter = var_node_maps.find(argument); | ||
| if (var_node_maps.end() == iter) { | ||
| VarDesc var_desc(patterns::UniqueKey(argument)); | ||
| node = graph->CreateVarNode(&var_desc); | ||
| var_node_maps.insert({argument, node}); | ||
| } else { | ||
| node = iter->second; | ||
| } | ||
| out_nodes.push_back(node); | ||
| arguments.push_back(node->Name()); | ||
| } | ||
| op_desc.SetOutput(var.parameter(), arguments); | ||
| } | ||
| // Set attribute for current operator. | ||
| for (const proto::OpDesc::Attr& attr : op.attrs()) { | ||
| op_desc.SetAttr(attr.name(), GetAttrValue(attr)); | ||
| } | ||
| // Create a Node for current operator. | ||
| Node* op_node = graph->CreateOpNode(&op_desc); | ||
| for (Node* node : in_nodes) { | ||
| IR_NODE_LINK_TO(node, op_node); | ||
| } | ||
| for (Node* node : out_nodes) { | ||
| IR_NODE_LINK_TO(op_node, node); | ||
| } | ||
| } | ||
| // Remove nodes that are intermediate. | ||
| std::unordered_set<const Node*> remove_nodes; | ||
| for (const std::unique_ptr<PDNode>& pdnode : pattern.nodes()) { | ||
| remove_nodes.emplace(subgraph.at(pdnode.get())); | ||
| } | ||
| for (auto iter : var_node_maps) { | ||
| remove_nodes.erase(iter.second); | ||
| } | ||
| GraphSafeRemoveNodes(graph, remove_nodes); | ||
| }; | ||
| return handler; | ||
| } | ||
|
|
||
| GeneratePass::GeneratePass(const std::string& binary_str) { | ||
| multi_pass_desc_.ParseFromString(binary_str); | ||
| VerifyDesc(); | ||
| } | ||
|
|
||
| GeneratePass::GeneratePass(const proto::MultiPassDesc& multi_pass_desc) | ||
| : multi_pass_desc_(multi_pass_desc) { | ||
| VerifyDesc(); | ||
| } | ||
|
|
||
| void GeneratePass::ApplyImpl(Graph* graph) const { | ||
| for (const proto::PassDesc& pass_desc : multi_pass_desc_.pass_descs()) { | ||
| GraphPatternDetector detector; | ||
| InitGeneratePattern(pass_desc, detector.mutable_pattern()); | ||
| detector(graph, GetGenerateRewrite(detector.pattern(), pass_desc)); | ||
| // The rewrited graph needs to be verified. Current Pass should be skipped | ||
| // if validation failed. Rewrite based on the original graph cannot | ||
| // implement rollback operation. | ||
| VerifyGraph(*graph); | ||
| } | ||
| } | ||
|
|
||
| void GeneratePass::VerifyDesc() const { | ||
| PADDLE_ENFORCE_NE(multi_pass_desc_.pass_descs_size(), 0, | ||
| platform::errors::InvalidArgument( | ||
| "Size of PassDesc should not be empty.")); | ||
| for (const proto::PassDesc& pass_desc : multi_pass_desc_.pass_descs()) { | ||
| // Check inputs/outputs of subgraph should in `var_maps`. | ||
| std::set<std::string> pattern_var_sets, replace_var_sets; | ||
| for (const proto::PassDesc::VarMap& var_map : pass_desc.var_maps()) { | ||
| pattern_var_sets.emplace(var_map.pattern_var()); | ||
| replace_var_sets.emplace(var_map.replace_var()); | ||
| } | ||
| auto check_vars = [=](std::set<std::string>* var_sets, | ||
| const proto::BlockDesc& block) { | ||
| for (const proto::OpDesc& op : block.ops()) { | ||
| for (const proto::OpDesc::Var& var : op.outputs()) { | ||
| for (const std::string& argument : var.arguments()) { | ||
| var_sets->emplace(argument); | ||
| } | ||
| } | ||
| } | ||
| for (const proto::OpDesc& op : block.ops()) { | ||
| for (const proto::OpDesc::Var& var : op.inputs()) { | ||
| for (const std::string& argument : var.arguments()) { | ||
| PADDLE_ENFORCE_NE( | ||
| var_sets->find(argument), var_sets->end(), | ||
| platform::errors::InvalidArgument( | ||
| "Subgraph of PassDesc has argument [%s] not in `var_maps`.", | ||
| argument)); | ||
| } | ||
| } | ||
| } | ||
| }; | ||
| check_vars(&pattern_var_sets, pass_desc.pattern().blocks(0)); | ||
| check_vars(&replace_var_sets, pass_desc.replace().blocks(0)); | ||
| } | ||
| } | ||
|
|
||
| bool GeneratePass::VerifyGraph(const Graph& graph) { | ||
| // Return true temporarily. | ||
| return true; | ||
| } | ||
|
|
||
| } // namespace ir | ||
| } // namespace framework | ||
| } // namespace paddle | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| // Copyright (c) 2021 PaddlePaddle Authors. All Rights Reserved. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| #pragma once | ||
| #include "paddle/fluid/framework/ir/graph_pattern_detector.h" | ||
| #include "paddle/fluid/framework/ir/pass.h" | ||
| #include "paddle/fluid/framework/pass_desc.pb.h" | ||
|
|
||
| namespace paddle { | ||
| namespace framework { | ||
| namespace ir { | ||
|
|
||
| // Generate a substitute pass from protobuf. | ||
| class GeneratePass : public Pass { | ||
| public: | ||
| // from binary_str | ||
| explicit GeneratePass(const std::string& binary_str); | ||
| // from PassDesc/MultiPassDesc | ||
| explicit GeneratePass(const proto::MultiPassDesc& multi_pass_desc); | ||
|
|
||
| protected: | ||
| void ApplyImpl(Graph* graph) const override; | ||
|
|
||
| private: | ||
| GeneratePass() = delete; | ||
| DISABLE_COPY_AND_ASSIGN(GeneratePass); | ||
| // Verify desc | ||
| void VerifyDesc() const; | ||
| // Verify graph | ||
| static bool VerifyGraph(const Graph& graph); | ||
|
|
||
| proto::MultiPassDesc multi_pass_desc_; | ||
| }; | ||
|
|
||
| } // namespace ir | ||
| } // namespace framework | ||
| } // namespace paddle |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we don't support cross block pass, we should mention it in python/c++ interface or API comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually, a subgraph is only in one block. We can support corss block in future if necessary.
I will add descriptions in next PR.