-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Support extern third_party lapack API on Linux/Windows/Mac #35690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your contribution! |
2533d4e to
ce8109e
Compare
ce8109e to
7452e63
Compare
16f2300 to
e8f1cb6
Compare
3b7cb1e to
21e18bd
Compare
3f977e2 to
755ff2b
Compare
755ff2b to
6bc60e4
Compare
6bc60e4 to
c6f76bc
Compare
2cf1962 to
ef0077b
Compare
ef0077b to
7172c54
Compare
fbf0924 to
a2319a1
Compare
a2319a1 to
b059930
Compare
b059930 to
d1d23e5
Compare
2f24f36 to
aa35604
Compare
e1c836d to
e15f9dc
Compare
e15f9dc to
4737457
Compare
JiabinYang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe need some test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need any other dtype support?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
还有两种复数类型,这里只是做示例,API同学可以继续往上加,数量非常多没有一一列举
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How to dispatch device?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
只有CPU的实现用lapack,这里原本只计划暴露lapack的裸API,但存在<mkl.h>互斥问题,所以做了一层简单包装,这个PR的目的是暴露出lapack的API。统一化的CPU、GPU的调度,还得再往上包一层更复杂的BLAS类,不在该PR计划里
demo 的用例已经放到inverse_op里做了测试,但demo用例没办法合入。后续需要API同学来触发真实case。 |
4737457 to
4dae087
Compare
4dae087 to
1e1c6b6
Compare
1e1c6b6 to
b254da8
Compare
jeff41404
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…lePaddle#35690) * support extern third_party lapack on Linux/Windows/Mac * fix ci
…lePaddle#35690) * support extern third_party lapack on Linux/Windows/Mac * fix ci
PR types
New features
PR changes
APIs
Describe
在Linux/Windows/Mac上引入第三方库Lapack函数:(https://github.com/Reference-LAPACK/lapack.git)
lapack API调用形式可以参考: