Skip to content

Conversation

@zhwesky2010
Copy link
Contributor

@zhwesky2010 zhwesky2010 commented Sep 13, 2021

PR types

New features

PR changes

APIs

Describe

在Linux/Windows/Mac上引入第三方库Lapack函数:(https://github.com/Reference-LAPACK/lapack.git)

infoflow 2021-09-16 16-29-06

lapack API调用形式可以参考:

infoflow 2021-09-16 16-06-38

infoflow 2021-09-16 16-06-57

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@zhwesky2010 zhwesky2010 force-pushed the lapack_Linux branch 2 times, most recently from 2f24f36 to aa35604 Compare September 17, 2021 15:23
@zhwesky2010 zhwesky2010 force-pushed the lapack_Linux branch 5 times, most recently from e1c836d to e15f9dc Compare September 18, 2021 07:55
Copy link
Contributor

@JiabinYang JiabinYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe need some test

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need any other dtype support?

Copy link
Contributor Author

@zhwesky2010 zhwesky2010 Sep 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还有两种复数类型,这里只是做示例,API同学可以继续往上加,数量非常多没有一一列举

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How to dispatch device?

Copy link
Contributor Author

@zhwesky2010 zhwesky2010 Sep 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

只有CPU的实现用lapack,这里原本只计划暴露lapack的裸API,但存在<mkl.h>互斥问题,所以做了一层简单包装,这个PR的目的是暴露出lapack的API。统一化的CPU、GPU的调度,还得再往上包一层更复杂的BLAS类,不在该PR计划里

@zhwesky2010
Copy link
Contributor Author

zhwesky2010 commented Sep 18, 2021

Maybe need some test

demo 的用例已经放到inverse_op里做了测试,但demo用例没办法合入。后续需要API同学来触发真实case。

Copy link
Contributor

@jeff41404 jeff41404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zhwesky2010 zhwesky2010 merged commit ae65257 into PaddlePaddle:develop Sep 22, 2021
@zhwesky2010 zhwesky2010 changed the title [2.2]support extern third_party lapack API on Linux/Windows/Mac support extern third_party lapack API on Linux/Windows/Mac Sep 22, 2021
@zhwesky2010 zhwesky2010 changed the title support extern third_party lapack API on Linux/Windows/Mac Support extern third_party lapack API on Linux/Windows/Mac Sep 22, 2021
lanxianghit pushed a commit that referenced this pull request Sep 22, 2021
ghost pushed a commit to piotrekobi/Paddle that referenced this pull request Sep 24, 2021
…lePaddle#35690)

* support extern third_party lapack on Linux/Windows/Mac

* fix ci
AnnaTrainingG pushed a commit to AnnaTrainingG/Paddle that referenced this pull request Sep 29, 2021
…lePaddle#35690)

* support extern third_party lapack on Linux/Windows/Mac

* fix ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants