add clip_by_norm fp16 kernel #35446
Merged
add clip_by_norm fp16 kernel #35446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Contributor
|
LGTM for TensorReduceFunctorImpl |
Aurelius84
approved these changes
Sep 6, 2021
Contributor
Aurelius84
left a comment
Aurelius84
left a comment
There was a problem hiding this comment.
LGTM for DataType Registarar.
chenwhql
approved these changes
Sep 8, 2021
| // merge ids in selected rows first | ||
| math::scatter::MergeAdd<platform::CUDADeviceContext, platform::float16> | ||
| merge_func; | ||
| SelectedRows* merged_input = |
Contributor
There was a problem hiding this comment.
这里不太理解为什么要将临时的merged_input放到scope中，看起来只是在kernel中使用的临时变量
phlrain
approved these changes
Sep 8, 2021
2742195759
pushed a commit
to 2742195759/Paddle
that referenced
this pull request
Sep 10, 2021
* add clip_by_norm fp16 kernel * add ut
AnnaTrainingG
pushed a commit
to AnnaTrainingG/Paddle
that referenced
this pull request
Sep 29, 2021
* add clip_by_norm fp16 kernel * add ut
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Describe
add clip_by_norm fp16 kernel