Skip to content

Conversation

@xiaoxiaohehe001
Copy link
Contributor

PR types

Function optimization

PR changes

OPs

Describe

增加op_converter中scale_op的单测

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@xiaoxiaohehe001 xiaoxiaohehe001 changed the title Add scale teller [Paddle Inference]Add scale TRT converter unittest. Aug 30, 2021

class TrtConvertScaleTest(TrtLayerAutoScanTest):
def is_program_valid(self, program_config: ProgramConfig) -> bool:
inputs = program_config.inputs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果program合理的话,直接返回True即可

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

program_config.ops[i].attrs
for i in range(len(program_config.ops))
]
if self.dims == 1:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里是指dims==1的时候,动态shape支持,静态shape不支持吗?


self.add_skip_case(
teller1, SkipReasons.TRT_NOT_SUPPORT,
"INPUT ScaleTensor and Shape NOT SUPPORT: we need to add support in the future"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果是日后需要支持的feature的话,请使用TRT_NOT_IMPLEMENTED

如果是trt本身不支持的,使用TRT_NOT_SUPPORT

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link

@cryoco cryoco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cryoco cryoco merged commit c563609 into PaddlePaddle:develop Sep 15, 2021
AnnaTrainingG pushed a commit to AnnaTrainingG/Paddle that referenced this pull request Sep 29, 2021
* add_scale_teller

* add_scale_teller

* add_scale_teller

* add_scale_teller

* add_scale_teller

* add_scale_teller

* add_scale_teller

* add_scale_teller

* add_scale_teller

* add_scale_teller

* add_scale_teller

* add_scale_teller

* add_scale_teller

* add_scale_teller
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants