Support dropout backward in eval mode#35122
Merged
guoshengCS merged 4 commits intoPaddlePaddle:developfrom Aug 26, 2021
Merged
Conversation
|
Thanks for your contribution! |
guoshengCS
reviewed
Aug 25, 2021
paddle/fluid/operators/dropout_op.h
Outdated
| if (platform::is_gpu_place(context.GetPlace()) && vec_size == 4 && | ||
| size % 4 == 0) { | ||
| if (context.Attr<bool>("is_test") == true) { | ||
| dX.device(place) = static_cast<T>(0) * dY; |
Contributor
There was a problem hiding this comment.
这里是1乘吧。另外is_test==true时应该也要分是否"upscale_in_train"来处理下。
guoshengCS
previously approved these changes
Aug 26, 2021
guoshengCS
reviewed
Aug 26, 2021
paddle/fluid/operators/dropout_op.h
Outdated
| if (platform::is_gpu_place(context.GetPlace()) && vec_size == 4 && | ||
| size % 4 == 0) { | ||
| float dropout_prob = context.Attr<float>("dropout_prob"); | ||
| dX.device(place) = dY / static_cast<T>(1.0f - dropout_prob); |
Contributor
There was a problem hiding this comment.
这里应该是dY * static_cast<T>(1.0f - dropout_prob);
guoshengCS
approved these changes
Aug 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
APIs
Describe
Support dropout backward in eval mode