Skip to content

fix convert ut framework problem #35112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jiweibo merged 2 commits into from
Aug 24, 2021
Merged

fix convert ut framework problem #35112

jiweibo merged 2 commits into from
Aug 24, 2021

Conversation

@jiweibo
Copy link
Contributor

@jiweibo jiweibo commented Aug 24, 2021

PR types

Bug fixes

PR changes

Others

Describe

  • convert单测框架修复没有权重无法save的问题（通过添加place_holder权重，避免用户再额外添加权重）
  • 找不到op output的问题（目前还有问题，无法推导出op out的var type，设置了输入的var_type，当遇到int64的op时，应该会挂）

@paddle-bot-old
Copy link

paddle-bot-old bot commented Aug 24, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

cryoco
cryoco approved these changes Aug 24, 2021
View reviewed changes
Copy link

@cryoco cryoco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiweibo jiweibo merged commit a8dee3b into PaddlePaddle:develop Aug 24, 2021
@jiweibo jiweibo deleted the convert_test branch August 24, 2021 12:25
@jiweibo jiweibo mentioned this pull request Aug 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cryoco cryoco cryoco approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jiweibo @cryoco