[CustomOp] Fix ext_tensor.cast failed bug#34884
Merged
chenwhql merged 5 commits intoPaddlePaddle:developfrom Aug 18, 2021
Merged
[CustomOp] Fix ext_tensor.cast failed bug#34884chenwhql merged 5 commits intoPaddlePaddle:developfrom
chenwhql merged 5 commits intoPaddlePaddle:developfrom
Conversation
jim19930609
approved these changes
Aug 17, 2021
| COMMAND ${CMAKE_COMMAND} -E copy_if_different "${final_path}/${src}.cc" "${final_path}/.${src}.cu" | ||
| COMMENT "create hidden file of ${src}.cu") | ||
| add_custom_target(${TARGET} ALL DEPENDS .${src}.cu) | ||
| add_custom_target(${TARGET} ALL DEPENDS ${final_path}/.${src}.cu) |
Contributor
There was a problem hiding this comment.
LoL, so we have a file named "ext_tensor.cu" for Linux Symlink, and a hidden ".ext_tensor.cu"(actually .ext_tensor.cu.cu) for Windows Symlink. What if there were a third/fourth... platform?
Contributor
There was a problem hiding this comment.
src is ext_tensor here. If system is based on Unix, these is no problem generally.
Contributor
Author
There was a problem hiding this comment.
we should remove these symlink cases later, include data_type_transform, tensor_utils, etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Describe
The code in macro
__NVCC__need to put into.cufile and compiled bynvcc.Before this PR, if we call
tensor.cast(x)and x.place is kGPU, it will throw error.