Skip to content

[hybrid] refine pipeline stage and mp send/recv check #34870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 13, 2021
Merged

[hybrid] refine pipeline stage and mp send/recv check #34870

merged 5 commits into from
Aug 13, 2021

Conversation

@wangxicoding
Copy link
Contributor

@wangxicoding wangxicoding commented Aug 13, 2021 •
edited
Loading

PR types

Others

PR changes

Others

Describe

  1. Refine pipeline stage check, move the check into insert_send_recv. Even if the stage is unordered, as long as send/recv inserted in order, it can pass the check.
  2. Remove the check of that size of send/recv var must be divisible by mp_degree. If it cannot be divisible, send/recv full data.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Aug 13, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@wangxicoding wangxicoding changed the title Pass pipeline check refine pipeline check Aug 13, 2021
@wangxicoding wangxicoding changed the title refine pipeline check refine pipeline stage and mp send/recv check Aug 13, 2021
@wangxicoding wangxicoding changed the title refine pipeline stage and mp send/recv check [hybrid] refine pipeline stage and mp send/recv check Aug 13, 2021
sandyhouse
sandyhouse approved these changes Aug 13, 2021
View reviewed changes
Copy link

@sandyhouse sandyhouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gongweibao gongweibao merged commit 2cd05d5 into PaddlePaddle:develop Aug 13, 2021
@wangxicoding wangxicoding deleted the pass_pipeline_check branch August 16, 2021 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sandyhouse sandyhouse sandyhouse approved these changes

@gongweibao gongweibao Awaiting requested review from gongweibao

@fuyinno4 fuyinno4 Awaiting requested review from fuyinno4

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wangxicoding @sandyhouse @gongweibao