Add matrix_rank Op and its GPU and CPU kernel #34823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
added 7 commits
August 16, 2021 08:19
0x45f
changed the title
Aurelius84
reviewed
Aug 30, 2021
Aurelius84
reviewed
Sep 3, 2021
zhiqiu
previously approved these changes
Sep 6, 2021
Contributor
zhiqiu
left a comment
zhiqiu
left a comment
There was a problem hiding this comment.
LGTM for op_function_generator.cc and ShareDataWith
dingjiaweiww
previously approved these changes
Sep 7, 2021
qingqing01
reviewed
Sep 7, 2021
Contributor
qingqing01
left a comment
qingqing01
left a comment
There was a problem hiding this comment.
LGTM for API. but need to update doc commets
0x45f
dismissed stale reviews from dingjiaweiww, XiaoguangHu01, zhiqiu, and Aurelius84
via
3f470cc
Aurelius84
approved these changes
Sep 7, 2021
zhhsplendid
approved these changes
Sep 8, 2021
zhiqiu
approved these changes
Sep 8, 2021
dingjiaweiww
approved these changes
Sep 8, 2021
0x45f
changed the title
AnnaTrainingG
pushed a commit
to AnnaTrainingG/Paddle
that referenced
this pull request
Sep 29, 2021
* init matrix_rank op, add matrix_rank CPU code and test * add GPU kernel, remove svd_eigen.h * add CPU kernel when tol is tensor * add cpu and gpu code when tol is tensor * fix CI-ROCM error * add matrix_rank API describe, fix PR-CI-Py3 error * fix PR-CI-Windows error, add matrix_rank API test * delete useless comments * fix review * add my code in svd_helper.h * update doc commets * remove spaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Describe
Add paddle.linalg.matrix_rank() function, matrix_rank Op and it's GPU/CPU kernel.