fix set_grad_ivar bug of Tensor.backward #34819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
zhwesky2010
force-pushed
the
fix_set_grad_var
branch
from
0312722 to
3cbe22d
Compare
zhwesky2010
force-pushed
the
fix_set_grad_var
branch
from
3cbe22d to
335c90f
Compare
zhwesky2010
force-pushed
the
fix_set_grad_var
branch
from
335c90f to
14f18e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Describe
手动设置的梯度是to_tensor出来的，to_tensor默认的stop_gradient为true，导致反向var的stop_gradient变成了true，而前向var为false，因此前向var认为可以创建反向OP，而反向var又在SetOutput时把自己从输出里剪掉了，这导致了后面到inplace时执行报错。
该PR修改了手动设置梯度的逻辑，修复了这个问题 。