Skip to content

[NPU] add pool2 op and tests#34770

Merged
ronny1996 merged 4 commits intoPaddlePaddle:developfrom
ronny1996:npu_pool2d
Aug 24, 2021
Merged

[NPU] add pool2 op and tests#34770
ronny1996 merged 4 commits intoPaddlePaddle:developfrom
ronny1996:npu_pool2d

Conversation

@ronny1996
Copy link
Contributor

@ronny1996 ronny1996 commented Aug 10, 2021

PR types

Others

PR changes

OPs

Describe

add pool2 op and tests
image
image
image

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

qili93
qili93 previously approved these changes Aug 20, 2021
Copy link
Contributor

@qili93 qili93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,改下头文件就可以

#include "paddle/fluid/framework/operator.h"
#include "paddle/fluid/operators/fill_constant_op.h"

#include "paddle/fluid/operators/npu_op_runner.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

15-20行的头文件应该都不需要

Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for shareDataWith

@ronny1996 ronny1996 merged commit da26173 into PaddlePaddle:develop Aug 24, 2021
@ronny1996 ronny1996 deleted the npu_pool2d branch September 9, 2021 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants