[CPU] Enable barrier op upon gloo #34671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
bliu3650
force-pushed
the
add_gloo_c_barrier_op_cpu
branch
from
562e071 to
0c1fdde
Compare
bliu3650
force-pushed
the
add_gloo_c_barrier_op_cpu
branch
from
0c1fdde to
defd61f
Compare
gongweibao
approved these changes
Aug 14, 2021
python/paddle/fluid/tests/unittests/test_collective_cpu_barrier_with_gloo.py
Outdated
Show resolved
Hide resolved
…unction from Python.
bliu3650
force-pushed
the
add_gloo_c_barrier_op_cpu
branch
from
bd8cd78 to
268163c
Compare
…add context release.
PangHua
approved these changes
Aug 17, 2021
PangHua
previously approved these changes
Aug 18, 2021
lanxianghit
reviewed
Aug 18, 2021
This comment has been minimized.
This comment has been minimized.
lanxianghit
previously approved these changes
Aug 19, 2021
XieYunshen
previously approved these changes
Aug 19, 2021
PangHua
previously approved these changes
Aug 19, 2021
…rt its init status.
… add_gloo_c_barrier_op_cpu
bliu3650
dismissed stale reviews from PangHua, XieYunshen, and lanxianghit
via
a736ebb
This comment has been minimized.
This comment has been minimized.
PangHua
previously approved these changes
Aug 20, 2021
PangHua
approved these changes
Aug 20, 2021
lanxianghit
approved these changes
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
APIs
Describe
Background:
Barrier operation from specific communication library (e.g. HCCL for Ascend cluster) was not stable, and backup solution with CPU barrier is required;
CPU barrier op was developed before but not verified;
Considering performance across thousands of machine to synchronize, calling barrier function directly is better than executing it with program;
Implementation:
Reuse previous barrier op implemented for CPU and add an initialization parallel environment flow for CPU only;
Both function-level call and op-level are supported;
Unittest:
test_collective_cpu_barrier_with_gloo.py