copy boost/any.hpp to utils and replace boost::any with self defined any #34613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenwhql
reviewed
Aug 9, 2021
cmake/inference_lib.cmake
Outdated
| SRCS ${PADDLE_SOURCE_DIR}/paddle/fluid/platform/float16.h | ||
| DSTS ${PADDLE_INFERENCE_INSTALL_DIR}/paddle/include/experimental/) | ||
| copy(inference_lib_dist | ||
| SRCS ${PADDLE_SOURCE_DIR}/paddle/fluid/utils/any.hpp |
Contributor
There was a problem hiding this comment.
是不是保持和我们的命名风格一致就可以了，any.hpp -> any.h
Contributor
There was a problem hiding this comment.
此外，是不是新建目录，放到paddle/utils下面比较好，主要考虑如下：
- 我们新组织的Tensor运算库会独立出来，不会依赖于fluid，而是由fluid依赖于Tensor运算库，如果这些utils还在fluid下的话，依赖关系拆不清楚
- 将来更多组件，比如lite也会合入到主repo，也可以共用这些utils，放在fluid下也不太合适
Shixiaowei02
previously approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Describe