fix dataloader exit terminate error#34501
Merged
heavengate merged 4 commits intoPaddlePaddle:developfrom Sep 16, 2021
Merged
Conversation
|
Thanks for your contribution! |
This was referenced Jul 30, 2021
830f573 to
34aa94b
Compare
qingqing01
approved these changes
Sep 14, 2021
AnnaTrainingG
pushed a commit
to AnnaTrainingG/Paddle
that referenced
this pull request
Sep 29, 2021
* fix DataLoader exit with SIGABRT/SIGSEGV. test=develop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
APIs
Describe
fix dataloader exit terminate error
fix
terminate called without an active exceptionif for loop break and program exit immediately(with no model layers processing) after iterate the first few data in distributed lauch mode, distributed launch will call terminate() to kill main process on each devices, but thread is still iterating to fullfill blocking queue caches, which may cause thread error
terminate called without an active exceptionfor terminate is a strong singal and__del__of DataLoader may not be called, so we add a global link to the last DataLoader instance to call__del__to clean up resourcestesting script
https://github.com/PaddlePaddle/PaddleNLP/blob/develop/examples/simultaneous_translation/stacl/train.py#L121
original error