[Cherry-pick] solve slice inplace illegal memory address bug (#34265) #34473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
lanxianghit
approved these changes
Jul 29, 2021
| d_input); | ||
| } | ||
| } else if (need_pad_num == 1) { | ||
| if (need_pad_num == 1) { |
Contributor
There was a problem hiding this comment.
测试时请关注对模型的性能影响，是否有明显的性能回退发生，后续可以看是否能把优化的问题修复
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
OPs
Describe
问题
decoupledsegnet、hardnet单卡，batch_size=1训练报错，问题定位于PR32266。
原因
经
cuda-memcheck排查发现在ElemwiseGradBroadcast2CUDAKernel处出现了非法内存访问导致出core。经分析原因在于Tensor实际分配大小与需求不一致，定位问题点在于SliceGradKernel的need_pad_num == 0判断有问题，直接跳过导致没有分配合适的空间，删去该判断逻辑后运行就正常了。