Logical Ops support more data types#34141
Merged
ZeyuChen merged 10 commits intoPaddlePaddle:developfrom Jul 23, 2021
Merged
Conversation
|
✅ This PR's description meets the template requirements! |
|
Thanks for your contribution! |
|
|
will-jl944
changed the title
will-jl944
force-pushed
the
logical_op_fix
branch
from
cd2a3ba to
af4943f
Compare
|
|
||
| REGISTER_OP_NPU_KERNEL(logical_and, | ||
| ops::LogicalAndPUKernel<plat::NPUDeviceContext, bool>); | ||
| ops::LogicalAndPUKernel<plat::NPUDeviceContext, bool>, |
Contributor
There was a problem hiding this comment.
LogicalAndPUKernel 请确认下这个类型名称；推理认为增加这些实例带来的体积增量 9 MB 有些大了，请给出一些原因吧，谢谢
Contributor
Author
Superjomn
approved these changes
Jul 19, 2021
Contributor
Superjomn
left a comment
Superjomn
left a comment
There was a problem hiding this comment.
因宏展开，推理库体积增加9M，GPU 4arch 预计增加36M，总体积增加 4.3%
这个PR 比较独立，先approve通过，后续也会看情况需不需要处理
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
OPs
Describe
Solve issue #34133 .
Logical Ops now support
bool,int8,int16,int32,int64,float, anddouble.