[NPU] add batch_norm_op_npu and test#34056
Merged
qili93 merged 3 commits intoPaddlePaddle:developfrom Aug 11, 2021
Merged
Conversation
|
Thanks for your contribution! |
ronny1996
force-pushed
the
npu_batch_norm
branch
from
7bdc804 to
14dcf87
Compare
ronny1996
force-pushed
the
npu_batch_norm
branch
from
14dcf87 to
53a439c
Compare
ronny1996
force-pushed
the
npu_batch_norm
branch
from
53a439c to
2891304
Compare
ronny1996
force-pushed
the
npu_batch_norm
branch
from
2891304 to
3b75b2a
Compare
qili93
requested changes
Jul 15, 2021
Contributor
There was a problem hiding this comment.
16-19行的头文件已经被batch_norm_op.h和npu_op_runner.h包含，可以不需要？
Contributor
There was a problem hiding this comment.
最好也参考 test_batch_norm_op.py把里面所有的test case加上，不能支持的就注释一下说明原因，尽量保证单测的coverage。
zhiqiu
reviewed
Jul 15, 2021
Comment on lines
165
to
173
Contributor
There was a problem hiding this comment.
Why add pinned allocator here? Is it needed in batch_norm op?
Contributor
Author
There was a problem hiding this comment.
It is no longer needed and has been removed
ronny1996
force-pushed
the
npu_batch_norm
branch
from
d7ed739 to
ad094b6
Compare
ronny1996
changed the title
ronny1996
force-pushed
the
npu_batch_norm
branch
from
7dbe170 to
db9e5ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
OPs
Describe
add batch_norm_op_npu and test