Skip to content

[NPU] add conv_op_npu and test#34055

Merged
ronny1996 merged 4 commits intoPaddlePaddle:developfrom
ronny1996:npu_conv_2d
Aug 24, 2021
Merged

[NPU] add conv_op_npu and test#34055
ronny1996 merged 4 commits intoPaddlePaddle:developfrom
ronny1996:npu_conv_2d

Conversation

@ronny1996
Copy link
Contributor

@ronny1996 ronny1996 commented Jul 9, 2021

PR types

Others

PR changes

OPs

Describe

add conv_op_npu and test
image

conv中还有一些未知BUG,暂时没有总结出BUG出现的规律
如groups=3, stride=[1,1], pad=[0,0], filter_size=[18, 3, 2, 2], input_size=[2,3,5,5], 反向会报错acl error code 507015
image

而filter_size=[18, 3, 3, 3]则不会报acl error

@paddle-bot-old
Copy link

paddle-bot-old bot commented Jul 9, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

把单测名字改成test_conv2d_op_npu.py, 里面单测的名字和case设计也尽量参考test_conv2d_op.py设计?尽量涵盖里面所有的单测case,这样可以在单测阶段就暴露问题,避免最后在模型精度对齐阶段再暴露就会比较难定位。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已更新

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it support fp16?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update

@ronny1996 ronny1996 requested review from qili93 and zhiqiu July 27, 2021 08:26
@ronny1996 ronny1996 changed the title add conv_op_npu and test [NPU] add conv_op_npu and test Aug 13, 2021
qili93
qili93 previously approved these changes Aug 20, 2021
Copy link
Contributor

@qili93 qili93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

85-86行可以删掉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已删

Copy link
Contributor

@qili93 qili93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for shareDataWith

@ronny1996 ronny1996 merged commit 00a269d into PaddlePaddle:develop Aug 24, 2021
@ronny1996 ronny1996 deleted the npu_conv_2d branch September 9, 2021 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants