Skip to content

refine varbase init function #34052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 9, 2021
Merged

refine varbase init function #34052

merged 2 commits into from
Jul 9, 2021

Conversation

@zhiqiu
Copy link
Contributor

@zhiqiu zhiqiu commented Jul 9, 2021 •
edited
Loading

PR types

Function optimization

PR changes

Others

Describe

  • Remove checks on kwargs in core.VarBase(). When use kwargs, it means the arguments is not required, but we add check on value, it is not needed.
    before
    image
    after
    image

  • Code refinement, split common function and reuse it.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Jul 9, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@zhiqiu zhiqiu requested a review from sneaxiy July 9, 2021 10:02
sneaxiy
sneaxiy approved these changes Jul 9, 2021
View reviewed changes
Copy link
Collaborator

@sneaxiy sneaxiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zhiqiu zhiqiu merged commit dfff52e into PaddlePaddle:develop Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sneaxiy sneaxiy sneaxiy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zhiqiu @sneaxiy