Skip to content

[NPU] add Wait after TensorCopy in uniform_random NPU OP#34005

Merged
pangyoki merged 1 commit intoPaddlePaddle:developfrom
pangyoki:fix_uniform_random_npu
Jul 7, 2021
Merged

[NPU] add Wait after TensorCopy in uniform_random NPU OP#34005
pangyoki merged 1 commit intoPaddlePaddle:developfrom
pangyoki:fix_uniform_random_npu

Conversation

@pangyoki
Copy link
Contributor

@pangyoki pangyoki commented Jul 7, 2021

PR types

Bug fixes

PR changes

OPs

Describe

CI单测有好多个挂了test_gelu_op_npu、test_matmulv2_op_npu、test_mul_op_npu、test_pow_op_npu、test_reduce_sum_op_npu、test_relu_op_npu、test_sgd_op_npu。
定位到是uniform random中数据拷贝错误导致的。

  • CPU到NPU的数据拷贝后,加Wait,防止数据拷贝出错

uniform_random单测中使用check_output_customized检查,不支持传入NPUPlace,所以检查不了在NPU上执行的情况。

  • check_output_customized添加传入place的参数。

图片

@paddle-bot-old
Copy link

paddle-bot-old bot commented Jul 7, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@qili93 qili93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pangyoki pangyoki merged commit cb73fee into PaddlePaddle:develop Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants