add num_iters in fit/evalate #33986
Merged
add num_iters in fit/evalate #33986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
heavengate
reviewed
Jul 7, 2021
python/paddle/hapi/model.py
Outdated
heavengate
reviewed
Jul 7, 2021
python/paddle/hapi/model.py
Outdated
Contributor
There was a problem hiding this comment.
说明一下None的时候会训练整个epoch，非None的时候训练num_iters次
ghostxsl
force-pushed
the
add_num_iters_in_fit
branch
from
2a26bf9 to
f98b2bd
Compare
qingqing01
requested review from
LielinJiang,
LiuChiachi,
jzhang533 and
qingqing01
heavengate
approved these changes
Jul 8, 2021
heavengate
changed the title
qingqing01
reviewed
Jul 9, 2021
| self.num_iters = num_iters | ||
| if num_iters is not None and isinstance(num_iters, int): | ||
| assert num_iters > 0, "num_iters must be greater than 0!" | ||
| epochs = (num_iters // steps) + 1 |
Contributor
There was a problem hiding this comment.
data loader是iterable style时， steps是None。 这里会出错。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
In the hapi, .fit() and .evaluate() is based on epoch, which is troublesome when users want to train a few iterations.