repair npu matmulv2_grad and comm_init_hccl #33719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
pangyoki
reviewed
Jun 23, 2021
| NpuOpRunner("BatchMatMul", {*x, *dout}, {*dy}, | ||
| {{"adj_x1", true}, {"adj_x2", false}}); | ||
| runner_dy.Run(stream); | ||
| if ((x->dims().size() == 3) && (dout->dims().size() == 3) && |
Contributor
There was a problem hiding this comment.
x dims为3，y dims为2的情况，前向是不是也不能用BatchMatMul
Contributor
Author
There was a problem hiding this comment.
前向可以，这里做了纬度判断是因为输出是个2纬，但是输入是两个3纬需要转化下
pangyoki
approved these changes
Jun 23, 2021
Contributor
pangyoki
left a comment
pangyoki
left a comment
There was a problem hiding this comment.
matmul v2 op fp16类型可能存在输入 3维 乘 2维的情况。BatchMatMul NPU op的fp32类型不支持这种情况。
目前情况下不会使用fp32数据类型，输入 3维 乘 2维的情况。所以暂时没对fp32做支持。
后续需要添加fp32类型对这种情况的处理。
wanghuancoder
approved these changes
Jun 23, 2021
Contributor
wanghuancoder
left a comment
wanghuancoder
left a comment
There was a problem hiding this comment.
LGTM for unittest.skipIf
void-main
reviewed
Jun 23, 2021
|
|
||
| // Build comm | ||
| float* buff; | ||
| int32_t size = 20; |
void-main
reviewed
Jun 23, 2021
| for (int32_t idx = 0; idx < size; idx++) { | ||
| input[idx] = 1.0; | ||
| } | ||
| aclrtMalloc(reinterpret_cast<void**>(&buff), size * sizeof(float), |
Contributor
There was a problem hiding this comment.
这种函数需要确保成功吧，得拿ACLCHECK包一下
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
OPs
Describe
1.repair npu matmulv2_grad supported 3*3->2 and add the UT test.
2.repair npu comm_init_hccl op by adding to send fake data to build connection.
matmul_gradv2 precision npu and gpu in fp16 for 5 epochs.
npu:
gpu:
