[HybridParallel] Add ParallelCrossEntropy for TensorParallel#33401
Merged
ForFishes merged 6 commits intoPaddlePaddle:developfrom Jun 9, 2021
Merged
[HybridParallel] Add ParallelCrossEntropy for TensorParallel#33401ForFishes merged 6 commits intoPaddlePaddle:developfrom
ForFishes merged 6 commits intoPaddlePaddle:developfrom
Conversation
|
Thanks for your contribution! |
sandyhouse
approved these changes
Jun 8, 2021
| if not return_softmax: | ||
| return loss | ||
| else: | ||
| return loss, softmax |
| PADDLE_ENFORCE_CUDA_SUCCESS(platform::dynload::ncclAllReduce( | ||
| predict_logits_buff, predict_logits_buff, predicted_logits.numel(), | ||
| platform::ToNCCLDataType(predicted_logits.type()), ncclSum, | ||
| comm->comm(), stream)); |
There was a problem hiding this comment.
should use #ifdef PADDLE_WITH_NCCL to use nccl function?
| PADDLE_ENFORCE_CUDA_SUCCESS(platform::dynload::ncclAllReduce( | ||
| sum_exp_logits_buff, sum_exp_logits_buff, sum_exp_logits.numel(), | ||
| platform::ToNCCLDataType(sum_exp_logits.type()), ncclSum, comm->comm(), | ||
| stream)); |
zhhsplendid
approved these changes
Jun 9, 2021
Member
zhhsplendid
left a comment
zhhsplendid
left a comment
There was a problem hiding this comment.
LGTM for ShareDataWith because the usage is similar to old softmax_with_cross_entropy_op
chenwhql
approved these changes
Jun 9, 2021
Contributor
chenwhql
left a comment
chenwhql
left a comment
There was a problem hiding this comment.
LGTM for PADDLE_ENFORCE in kernel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
APIs
Describe
[HybridParallel] Add ParallelCrossEntropy for TensorParallel