-
Notifications
You must be signed in to change notification settings - Fork 5.9k
[Paddle-TRT] Add gather_nd and reduce_sum trt op. #33324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your contribution! |
chenwhql
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for PADDLE_ENFORCE
|
|
||
| nvinfer1::ILayer* layer = nullptr; | ||
| if (engine_->with_dynamic_shape()) { | ||
| #if IS_TRT_VERSION_GE(6000) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
现在可以不加这个检查了,我们不支持TRT6以下版本了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
| inputs.emplace_back(index); | ||
|
|
||
| nvinfer1::ILayer* layer = nullptr; | ||
| if (engine_->with_dynamic_shape()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我看在op_teller里已经有这个判断了,这里是不是不用再加了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
| bool keep_dim = BOOST_GET_CONST(bool, op_desc.GetAttr("keep_dim")); | ||
| std::vector<int32_t> dim = | ||
| BOOST_GET_CONST(std::vector<int32_t>, op_desc.GetAttr("dim")); | ||
| bool reduce_all = BOOST_GET_CONST(bool, op_desc.GetAttr("reduce_all")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这些属性可以在op_teller里判断是否有,没有的话就不转TRT了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
cryoco
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR types
Others
PR changes
Others
Describe