Skip to content

Conversation

@jiweibo
Copy link
Contributor

@jiweibo jiweibo commented Jun 3, 2021

PR types

Others

PR changes

Others

Describe

  • Add gather_nd trt dynamic plugin and converter.
  • Add reduce_sum trt converter.
  • Fix multihead_matmul plugin when input seq_len > 1024.
  • Fix emb_eltwise_layernorm plugin when ernie has >3 input.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Jun 3, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

chenwhql
chenwhql previously approved these changes Jun 4, 2021
Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for PADDLE_ENFORCE


nvinfer1::ILayer* layer = nullptr;
if (engine_->with_dynamic_shape()) {
#if IS_TRT_VERSION_GE(6000)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

现在可以不加这个检查了,我们不支持TRT6以下版本了

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

inputs.emplace_back(index);

nvinfer1::ILayer* layer = nullptr;
if (engine_->with_dynamic_shape()) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我看在op_teller里已经有这个判断了,这里是不是不用再加了

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment on lines +49 to +52
bool keep_dim = BOOST_GET_CONST(bool, op_desc.GetAttr("keep_dim"));
std::vector<int32_t> dim =
BOOST_GET_CONST(std::vector<int32_t>, op_desc.GetAttr("dim"));
bool reduce_all = BOOST_GET_CONST(bool, op_desc.GetAttr("reduce_all"));
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这些属性可以在op_teller里判断是否有,没有的话就不转TRT了

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link

@cryoco cryoco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiweibo jiweibo merged commit d194bd3 into PaddlePaddle:develop Jun 5, 2021
@jiweibo jiweibo deleted the dqa_ernie branch June 5, 2021 00:16
jiweibo added a commit to jiweibo/Paddle that referenced this pull request Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants