Skip to content

Add bf16 support for save and load ops #33173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 17, 2021
Merged

Add bf16 support for save and load ops #33173

merged 6 commits into from
Jun 17, 2021

Conversation

@wozna
Copy link
Contributor

@wozna wozna commented May 27, 2021

PR types

New features

PR changes

OPs

Describe

This PR adds:

  • BF16 support for ops: (save, save_combine, load, load_combine)
  • an enablement of save_inference_model for pure_bf16 in test_fit_a_line.py

@paddle-bot-old
Copy link

paddle-bot-old bot commented May 27, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@wozna
Copy link
Contributor Author

wozna commented May 31, 2021

@arlesniak @arogowie-intel Could you please start your review?

arlesniak
arlesniak reviewed May 31, 2021
View reviewed changes
arogowie-intel
arogowie-intel previously approved these changes Jun 1, 2021
View reviewed changes
arlesniak
arlesniak previously approved these changes Jun 1, 2021
View reviewed changes
Copy link
Contributor

@arlesniak arlesniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wozna
Copy link
Contributor Author

wozna commented Jun 2, 2021

@pengjuncai Could you please start your review?

1 similar comment
@arlesniak
Copy link
Contributor

arlesniak commented Jun 8, 2021

@pengjuncai Could you please start your review?

@paddle-bot-old
Copy link

paddle-bot-old bot commented Jun 9, 2021

Sorry to inform you that 006565e's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@chenwhql
Copy link
Contributor

chenwhql commented Jun 10, 2021

this unittest is failed now, maybe need to fix it firstly

image

@wozna wozna dismissed stale reviews from arlesniak and arogowie-intel via 009a015 June 10, 2021 15:20
@wozna
Copy link
Contributor Author

wozna commented Jun 14, 2021

Test timeout has already been fixed, by reducing the number of iterations of the model.
@arlesniak @arogowie-intel Could you please start your review?

arlesniak
arlesniak approved these changes Jun 14, 2021
View reviewed changes
Copy link
Contributor

@arlesniak arlesniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wozna
Copy link
Contributor Author

wozna commented Jun 14, 2021

@chenwhql Test timeout has already been fixed. Could you please start your review?

jczaja
jczaja approved these changes Jun 14, 2021
View reviewed changes
Copy link
Contributor

@jczaja jczaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lidanqing-vv
Copy link
Contributor

lidanqing-vv commented Jun 15, 2021

@chenwhql Could you please continue your review? If no problems please approve and merge ?

hbwx24
hbwx24 approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@hbwx24 hbwx24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wzzju
wzzju approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@wzzju wzzju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

chenwhql
chenwhql approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wanghuancoder
wanghuancoder approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for @unittest.skipIf

@wzzju wzzju merged commit 832a014 into PaddlePaddle:develop Jun 17, 2021
@wozna wozna deleted the bf16_save branch February 24, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wzzju wzzju wzzju approved these changes

@hbwx24 hbwx24 hbwx24 approved these changes

@chenwhql chenwhql chenwhql approved these changes

@wanghuancoder wanghuancoder wanghuancoder approved these changes

@arogowie-intel arogowie-intel Awaiting requested review from arogowie-intel

+2 more reviewers

@jczaja jczaja jczaja approved these changes

@arlesniak arlesniak arlesniak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

BF16 Intel

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@wozna @arlesniak @chenwhql @lidanqing-vv @jczaja @wzzju @hbwx24 @wanghuancoder @arogowie-intel