Fix cuda kernel launch of grid sampler#33100
Merged
wanghaoshuang merged 3 commits intoPaddlePaddle:developfrom May 31, 2021
Merged
Fix cuda kernel launch of grid sampler#33100wanghaoshuang merged 3 commits intoPaddlePaddle:developfrom
wanghaoshuang merged 3 commits intoPaddlePaddle:developfrom
Conversation
|
Thanks for your contribution! |
jerrywgz
previously approved these changes
May 27, 2021
Contributor
Author
关于benchmark CI failing的说明对于inputs: 在该PR之前, block_size = 4256246 / 512, grid_size = 512, block_size超过了max_thread_num, 所以计算结果实际是错误的。 benchmark部分超时log如下: |
| self.mode = "bilinear" | ||
|
|
||
| def test_check_grad_normal(self): | ||
| pass |
Contributor
There was a problem hiding this comment.
- large input导致慢的原因是单测框架的期望梯度算的较慢吧?有测过大概需要多久吗
- 如果已经用了skip_check_grad_ci,下面259~260就不需要写了
Contributor
Author
There was a problem hiding this comment.
- 是的,单测框架的期望梯度算的较慢。单个case跑了20min,还没有完成。
- 已删除259~260
53903ae to
47dfe55
Compare
zhangting2020
previously approved these changes
May 31, 2021
Contributor
zhangting2020
left a comment
There was a problem hiding this comment.
LGTM for skip_check_grad_ci
47dfe55 to
1175e54
Compare
zhangting2020
approved these changes
May 31, 2021
chalsliu
approved these changes
May 31, 2021
wanghaoshuang
added a commit
to wanghaoshuang/Paddle
that referenced
this pull request
May 31, 2021
XiaoguangHu01
pushed a commit
that referenced
this pull request
Jun 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
OPs
Describe
Fix cuda kernel launch of grid sampler
Fix #29066