Skip to content

Add AXPY oneDNN handler#33046

Closed
arogowie-intel wants to merge 13 commits intoPaddlePaddle:developfrom
arogowie-intel:aosewski/axpy
Closed

Add AXPY oneDNN handler#33046
arogowie-intel wants to merge 13 commits intoPaddlePaddle:developfrom
arogowie-intel:aosewski/axpy

Conversation

@arogowie-intel
Copy link
Contributor

@arogowie-intel arogowie-intel commented May 21, 2021

PR types

Performance optimization

PR changes

OPs

Describe

This PR introduces oneDNN AXPY handler providing BLAS::AXPY interface. The use of this handler is enabled at this moment only for bfloat16 data type for sum operator with SelectedRows input tensors. It gives almost 10% performance improvement on CPX machine.

Additionally this PR speeds up SGD operator with Selected rows with AXPY handler.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@arogowie-intel arogowie-intel self-assigned this May 21, 2021
@arogowie-intel arogowie-intel marked this pull request as draft May 21, 2021 14:37
@paddle-bot-old
Copy link

Sorry to inform you that c7b8f49's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@arogowie-intel arogowie-intel marked this pull request as ready for review June 10, 2021 13:52
@arogowie-intel
Copy link
Contributor Author

CI-APPROVAL failure is because of need for approval to skip test:

2021-06-10 21:52:47 0. Unittest is not allowed to be disabled.
2021-06-10 21:52:47 You must have one RD (kolinwei(Recommend), wanghuancoder or luotao1) approval for the usage of @unittest.skip or @unittest.skipIf.
2021-06-10 21:52:47 +@**unittest.skipIf(not core.supports_bfloat16()**

jczaja
jczaja previously approved these changes Jun 10, 2021
Copy link
Contributor

@jczaja jczaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

arlesniak
arlesniak previously approved these changes Jun 10, 2021
Copy link
Contributor

@arlesniak arlesniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arogowie-intel arogowie-intel dismissed stale reviews from arlesniak and jczaja via 2dc3135 June 11, 2021 07:56
Copy link
Contributor

@arlesniak arlesniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arogowie-intel
Copy link
Contributor Author

@lidanqing-intel PR-CI-APPROVAL failed because of use of unittest.skipIf(not core.supports_bfloat16() and I need sb's approval for this.
@jczaja PR-CI-OP-benchmark fails in GPU tests for reasons not related to this PR. I rerun it for the third time.

@lidanqing-vv lidanqing-vv self-requested a review June 17, 2021 04:06
Copy link
Contributor

@lidanqing-vv lidanqing-vv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lidanqing-vv
Copy link
Contributor

mkldnn bf16 ops tests always use unittest.skipIf(not core.supports_bfloat16()
Just like in other bf16 ops PRs https://github.com/PaddlePaddle/Paddle/pull/33172/files
so it can be approved.

@lidanqing-vv
Copy link
Contributor

lidanqing-vv commented Jun 22, 2021

Hi, @arogowie-intel I cherry-picked your PR and it's been merged. You may close this.
By inheritance, you may avoid unittest.skipIf(not core.supports_bfloat16(). Since now Luotao left, approval requires other Baidu people to review and take long time.

@lidanqing-vv
Copy link
Contributor

#33632 has merged this PR. So I close this one because we need to summarise merged PRs each week.

@arogowie-intel arogowie-intel deleted the aosewski/axpy branch June 28, 2021 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants