Polish code for setitem and getitem#32911
Merged
liym27 merged 2 commits intoPaddlePaddle:developfrom May 20, 2021
Merged
Conversation
|
Thanks for your contribution! |
|
✅ This PR's description meets the template requirements! |
liym27
force-pushed
the
polish_slice_code_2
branch
from
8cd0d1b to
b4e5b1c
Compare
liym27
force-pushed
the
polish_slice_code_2
branch
from
b4e5b1c to
cdbd139
Compare
liym27
force-pushed
the
polish_slice_code_2
branch
from
cdbd139 to
35b7433
Compare
zhhsplendid
reviewed
May 20, 2021
| from . import unique_name | ||
| from . import core | ||
|
|
||
| MAX_INTEGER = 2**31 - 1 |
Contributor
Author
There was a problem hiding this comment.
No.
sys.maxsize is 2**63 - 1. Because the maximum of c++ int is 2**31 - 1, pass 2**63 - 1 from Python to c++ will result in data out of bounds.
liym27
added a commit
to liym27/Paddle
that referenced
this pull request
Jun 11, 2021
This was referenced Jun 11, 2021
lanxianghit
pushed a commit
that referenced
this pull request
Jun 15, 2021
…ist/Tensor/None/Ellipsis/bool (#33528) * [cherry-pick 2.1] Polish code for _getitem_impl_ (#32868) * [cherry-pick] Polish code for setitem and getitem (#32911) * [slice getitem] Support getitem idx is Tensor or List (#33000) * [getitem] Support index is None for getitem in static mode (#33001) * [Static getitem] Support static Variable getitem for Ellipsis index (#32876) * [static getitem]Support index is list bool for getitem in static mode (#33298)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
APIs
Describe
As the title