remove packages in __all__#32759
Merged
XiaoguangHu01 merged 4 commits intoPaddlePaddle:developfrom May 7, 2021
zhiboniu:develop_fix
Merged
remove packages in __all__#32759XiaoguangHu01 merged 4 commits intoPaddlePaddle:developfrom zhiboniu:develop_fix
XiaoguangHu01 merged 4 commits intoPaddlePaddle:developfrom
zhiboniu:develop_fix
Conversation
| 'clip', | ||
| 'Softplus', | ||
| 'KLDivLoss', | ||
| 'clip_by_norm', |
Contributor
There was a problem hiding this comment.
这个API虽然放在这里不太合适，但不能直接删除。
- 建议放到paddle.clip_by_norm位置，跟paddle.clip放一起，表示是对基础Tensor的一个操作。
- 这里的api先保留，但需要打印deprecated警告
Contributor
Author
There was a problem hiding this comment.
clip_by_norm没有真是实现，剔除空名
| 'deprecated', | ||
| 'download', | ||
| 'run_check', | ||
| 'unique_name', |
Contributor
There was a problem hiding this comment.
unique_name虽然是一个文件，但底层的API需要暴露
比如：paddle.utils.unique_name.guard()
Contributor
Author
There was a problem hiding this comment.
done，再paddle/utils新增unique_name.py文件开放__all__列表
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
APIs
Describe
remove packages left in all