Skip to content

Conversation

@zhiboniu
Copy link
Contributor

@zhiboniu zhiboniu commented May 6, 2021

PR types

Others

PR changes

APIs

Describe

remove packages left in all

@zhiboniu zhiboniu changed the title Develop fix remove packages in __all__ May 6, 2021
jzhang533
jzhang533 previously approved these changes May 7, 2021
Copy link
Contributor

@jzhang533 jzhang533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

'clip',
'Softplus',
'KLDivLoss',
'clip_by_norm',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个API虽然放在这里不太合适,但不能直接删除。

  1. 建议放到paddle.clip_by_norm位置,跟paddle.clip放一起,表示是对基础Tensor的一个操作。
  2. 这里的api先保留,但需要打印deprecated警告

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clip_by_norm没有真是实现,剔除空名

'deprecated',
'download',
'run_check',
'unique_name',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unique_name虽然是一个文件,但底层的API需要暴露
比如:paddle.utils.unique_name.guard()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done,再paddle/utils新增unique_name.py文件开放__all__列表

XiaoguangHu01
XiaoguangHu01 previously approved these changes May 7, 2021
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jzhang533 jzhang533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XiaoguangHu01 XiaoguangHu01 merged commit a77ade0 into PaddlePaddle:develop May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants