Skip to content

[Paddle-TRT]fix trt-converter-fc_op#32671

Merged
cryoco merged 10 commits intoPaddlePaddle:developfrom
Wangzheee:fc_op
May 8, 2021
Merged

[Paddle-TRT]fix trt-converter-fc_op#32671
cryoco merged 10 commits intoPaddlePaddle:developfrom
Wangzheee:fc_op

Conversation

@Wangzheee
Copy link
Contributor

PR types

Others

PR changes

Others

Describe

重写converter的fc_op,能支持动态、静态、int8输入,增加单测的情况

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@cryoco cryoco requested review from cryoco and shangzhizhou and removed request for shangzhizhou April 29, 2021 04:14
Comment on lines +63 to +67
PADDLE_ENFORCE_GE(x_num_col_dims, 1,
platform::errors::InvalidArgument(
"converter expects x_num_col_dims >= 1, but "
"x_num_col_dims = %d.",
x_num_col_dims));
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个检查放到op_teller里吧

Copy link

@cryoco cryoco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cryoco cryoco merged commit 62d848d into PaddlePaddle:develop May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants