Skip to content

[ROCM] update PADDLE_WITH_ROCM to PADDLE_WITH_HIP, test=develop #32487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2021
Merged

[ROCM] update PADDLE_WITH_ROCM to PADDLE_WITH_HIP, test=develop #32487

merged 1 commit into from
Apr 25, 2021

Conversation

@qili93
Copy link
Contributor

@qili93 qili93 commented Apr 23, 2021 •
edited
Loading

PR types

Bug fixes

PR changes

OPs

Describe

update PADDLE_WITH_ROCM to PADDLE_WITH_HIP, fix PR#32114

@paddle-bot-old
Copy link

paddle-bot-old bot commented Apr 23, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Avin0323
Avin0323 approved these changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@Avin0323 Avin0323 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wanghuancoder
wanghuancoder approved these changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Apr 23, 2021
@PaddlePaddle PaddlePaddle unlocked this conversation Apr 23, 2021
@qili93 qili93 merged commit 3b4dcad into PaddlePaddle:develop Apr 25, 2021
@qili93 qili93 deleted the fix_rocm2hip branch April 25, 2021 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Avin0323 Avin0323 Avin0323 approved these changes

@wanghuancoder wanghuancoder wanghuancoder approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@qili93 @Avin0323 @wanghuancoder