Skip to content

add get_loss_scaling to fleet#32401

Merged
wangxicoding merged 1 commit intoPaddlePaddle:developfrom
FeixLiu:develop
Apr 21, 2021
Merged

add get_loss_scaling to fleet#32401
wangxicoding merged 1 commit intoPaddlePaddle:developfrom
FeixLiu:develop

Conversation

@FeixLiu
Copy link
Contributor

@FeixLiu FeixLiu commented Apr 21, 2021

PR types

Others

PR changes

APIs

Describe

add get_loss_scaling method to fleet
add an assertion to get_loss_scaling method to fluid

@CLAassistant
Copy link

CLAassistant commented Apr 21, 2021

CLA assistant check
All committers have signed the CLA.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Apr 21, 2021

✅ This PR's description meets the template requirements!
Please wait for other CI results.

def get_loss_scaling(self):
"""Return the real-time loss scaling factor.
"""
assert self._loss_scaling is not None, 'Call minimize() before calling get_loss_scaling()'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

加一个敬语Please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

下个pr一起改

Copy link
Contributor

@wangxicoding wangxicoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangxicoding wangxicoding merged commit 37bb334 into PaddlePaddle:develop Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants