Skip to content

Conversation

@ronny1996
Copy link
Contributor

PR types

Others

PR changes

Others

Describe

bugfix for unittest

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@ronny1996 ronny1996 force-pushed the rocm-dev-2 branch 2 times, most recently from 7347912 to 2b38b1f Compare April 22, 2021 08:20
@ronny1996 ronny1996 force-pushed the rocm-dev-2 branch 2 times, most recently from 96fd5be to 9c66e1c Compare April 25, 2021 06:35
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

多一行注释删掉一下

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已删除

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里需要保留NOT ${CUDNN_VERSION} VERSION_LESS 7100

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已更新

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

确认下这段代码为什么需要挪到上面去?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已改回

@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Apr 30, 2021
@PaddlePaddle PaddlePaddle unlocked this conversation Apr 30, 2021
@ronny1996 ronny1996 requested a review from qili93 May 6, 2021 02:02
Copy link
Contributor

@qili93 qili93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qili93 qili93 merged commit 3139262 into PaddlePaddle:develop May 6, 2021
@ronny1996 ronny1996 deleted the rocm-dev-2 branch November 16, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants